Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Carl Quist <equalizerjr@gmail.com>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH] ALSA: hda/realtek: Enable mute LED on HP Laptop 15-dy0xxx
Date: Thu, 06 Aug 2026 11:48:23 +0200	[thread overview]
Message-ID: <87mruzeg0o.wl-tiwai@suse.de> (raw)
In-Reply-To: <CAOtcGaxXndKxTK5MVSEcmF-LUy+V51K7fhE=qvLA+VvW5ZyCNA@mail.gmail.com>

On Thu, 06 Aug 2026 01:57:27 +0200,
Carl Quist wrote:
> 
> 
> The mute LED on the HP Laptop 15-dy0xxx (PCI SSID 103c:864f, Realtek
> ALC236) does not work, because the machine has no entry in the quirk
> table. No fixup is applied, so no mute LED classdev is registered and
> nothing ever drives the LED.
> 
> The LED is controlled by COEF index 0x07, bit 0. This was verified on
> the hardware with hda-verb: setting the bit lights the mute LED and
> clearing it turns the LED off.
> 
>   hda-verb /dev/snd/hwC0D0 0x20 SET_COEF_INDEX 0x07
>   hda-verb /dev/snd/hwC0D0 0x20 SET_PROC_COEF 0x1     # LED on
>   hda-verb /dev/snd/hwC0D0 0x20 SET_PROC_COEF 0x200   # LED off
> 
> That is exactly what ALC236_FIXUP_HP_MUTE_LED_COEFBIT2 configures, and
> the closely related HP Laptop 15-dw0xxx (103c:85f0) already uses it.
> Bit 9 (0x200) is set by default on this board and is preserved by the
> fixup's read-modify-write.
> 
> Tested on an HP Laptop 15-dy0xxx (SKU 7FU54UA#ABA, board 864F,
> BIOS F.40).
> 
> Signed-off-by: Carl Quist <equalizerjr@gmail.com>

Applied now.  But at the next time, please submit to
linux-sound@vger.kernel.org, instead.  It's the place for kernel
patches.


thanks,

Takashi

      reply	other threads:[~2026-08-06  9:49 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-05 23:57 [PATCH] ALSA: hda/realtek: Enable mute LED on HP Laptop 15-dy0xxx Carl Quist
2026-08-06  9:48 ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mruzeg0o.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=equalizerjr@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox