From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 53968C53209 for ; Mon, 27 Jul 2026 13:55:44 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [45.14.194.44]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id A43A760201; Mon, 27 Jul 2026 15:55:31 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz A43A760201 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1785160541; bh=sFrrgUKzMof5B+VPmslO7WHXpevCcOnmBYYkSt2sv8w=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=cWELtCqt9myIBsgxKW99b+NrGr6gGMX0/9qAbV2YXPB4heoWqatCxS7lbmsVE0M16 Wtqp40rA/v916jWqGEXGGE8uHJ770FU2LNsvDZ3+PT6q+Tm21z2NyNhNE3FffGX5Jk m8mFYuwPuy6nIcRAv2+CoLUptSNHEKHZiT06q4S8= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 5B418F805FD; Mon, 27 Jul 2026 15:55:04 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id A7D18F805FF; Mon, 27 Jul 2026 15:55:04 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 469E1F80526; Mon, 27 Jul 2026 15:54:57 +0200 (CEST) Authentication-Results: alsa1.perex.cz; arc=none smtp.remote-ip=195.135.223.130 ARC-Seal: i=1; d=alsa-project.org; s=arc; a=rsa-sha256; cv=none; t=1785160492; b=L0uK9pT6S77ekYEa88SDNBaGgoFTw07LbegRZrFYP3tOxHuGKgnVfixvUpk7fUKpWEry 3602uX69Gy63CXTJdQHeIheVjYlO6CDl4fqVO/jUxiLBJhAhgbHPqtUeqk+MEmZx7twPa /maMFvpvG/SN/UubibN0NpZrMNlW62CviHzH6CxylplXm2RKGgsRA8J0wa9iLLXQYrbgM b/5pC1DysMPkl/8hwdHarL0iJafzFT5UuIawrkwXubaPZHmihpILGtAIYEmqECNyeKG6C uRZL6f7BEbng59bsrZe1REYW674dz+Jww6Go7e18iy0NmrhYfiKmlkej+TOW0M4dk9Q== ARC-Message-Signature: i=1; d=alsa-project.org; s=arc; a=rsa-sha256; c=relaxed/simple; t=1785160492; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:Date: Message-ID:From:To:Subject:MIME-Version; bh=sFrrgUKzMof5B+VPmslO7WHXpevCcOnmBYYkSt2sv8w=; b=pnEs0/Hi9zMc8twZORz97cT9ayzq1V3iNYXLJ9uZcswf0P9avTRlejposkgIFzg++VMS jZinb65KOnyTB3uer0o/IxSzq3vPB7+TUpdp+ggQeEYy3/q4oNqXhzIh4Y4jP8VJQNEVz LIhL4gbnEZuWtnm0UBA9VNXkYcrgUIe/ZadMmjz4/WDxIjrWjIQXtci6Os+AkxXX/kX62 Ylize2di0oKJx9m86LP321A9cWatEty/+vGk1tEWDiuTSp8GJ7+80H3YplDqc0jk4atSO lRRlAM+wBaJ8NCGBu7NkOC3KHdFgTC+M1JFhcK4afXxgo/v6ALIYiisrFYvyU95bDNg== ARC-Authentication-Results: i=1; alsa1.perex.cz; dkim=pass header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=KyHnHYOO; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=mTPAqLGp; dkim=pass header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=0AwkG0t5; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=bPBV6Lcz; arc=none smtp.remote-ip=195.135.223.130 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 9D1DAF8025A for ; Mon, 27 Jul 2026 15:54:51 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 9D1DAF8025A Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=KyHnHYOO; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=mTPAqLGp; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=0AwkG0t5; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=bPBV6Lcz Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 1813E7BD6F; Mon, 27 Jul 2026 13:54:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1785160486; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=gSZm4u8vpcG2jH3ttpbaeJeRrcL1TQ4PCMa9vn3S2Q4=; b=KyHnHYOOdkwQNL9drwkAT7LSD85O4rZA2zGfpjgbnjgBMKx/PgughuBwp+wgsv8os6sYik adrmTFtD02L65/lbyISomI2yiipQmYv/pjpQa6l8u4Lo5l3CphfyfYOqTba/3tJgv3VFMz eyZxb9eVh3d9DYy/P9KAQ4qjXsWjqno= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1785160486; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=gSZm4u8vpcG2jH3ttpbaeJeRrcL1TQ4PCMa9vn3S2Q4=; b=mTPAqLGp4bAkz1VlaEuM/GsbuTNj0nHq1nUVVV5q4I0WApiDZAiPWCvlYgJ+ZXdG3QRRX7 L1OBMBlmrmaTiXCA== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1785160482; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=gSZm4u8vpcG2jH3ttpbaeJeRrcL1TQ4PCMa9vn3S2Q4=; b=0AwkG0t5MLsUvIelFsyDOa3xNpYPAbYpuxgy9yPHmbRrGYbA2hzZURE/Hjftb9KfMTKY8R 9WUp5OHLtgjz+uWMT7i/4v22VG0dhN5yZscmZ2kGvMdMOgD84m1KQDwJxqaVllJCFPZX3k OJikZb+uK9ODUduaYYUJK33d1gHQBck= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1785160482; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=gSZm4u8vpcG2jH3ttpbaeJeRrcL1TQ4PCMa9vn3S2Q4=; b=bPBV6LczUAK48bGVm7HMFsx5eqt/g62mT/3Kmlk4EtGKSx4tYLZH95AC+R1fvW6FnVftMt 9JkkUWahsifgOwCQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id E77FE779C1; Mon, 27 Jul 2026 13:54:41 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id NQ7oNiFjZ2qwIgAAD6G6ig (envelope-from ); Mon, 27 Jul 2026 13:54:41 +0000 Date: Mon, 27 Jul 2026 15:54:41 +0200 Message-ID: <87mrvc8rmm.wl-tiwai@suse.de> From: Takashi Iwai To: Michael Diesen Cc: linux-sound@vger.kernel.org, alsa-devel@alsa-project.org Subject: Re: [PATCH v2] ALSA: hda/realtek: Add quirk for HP Dragonfly Folio G3 2-in-1 (103c:8a05) In-Reply-To: <20260727091920.4634-1-michael.diesen@posteo.de> References: <874ii84j3p.wl-tiwai@suse.de> <20260727091920.4634-1-michael.diesen@posteo.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/30.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-Spamd-Result: default: False [-3.30 / 50.00]; BAYES_HAM(-3.00)[100.00%]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-0.999]; MIME_GOOD(-0.10)[text/plain]; MIME_TRACE(0.00)[0:+]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_DN_SOME(0.00)[]; ARC_NA(0.00)[]; RCVD_TLS_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; FROM_EQ_ENVFROM(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,suse.de:mid] Message-ID-Hash: CJSW6I6OMTZL5ZNDHLZAYHTPZISETS2K X-Message-ID-Hash: CJSW6I6OMTZL5ZNDHLZAYHTPZISETS2K X-MailFrom: tiwai@suse.de X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Mon, 27 Jul 2026 11:19:21 +0200, Michael Diesen wrote: > > The HP Dragonfly Folio G3 2-in-1 also ships with PCI SSID 103c:8a05. > On this unit the ALC245 codec reports subsystem id 103c:8a06 - the SSID > that is already covered by commit 0a10faad5ca5 ("ALSA: hda/realtek: add > quirk for HP Dragonfly Folio G3 2-in-1") - while the PCI SSID that > SND_PCI_QUIRK matches against is 103c:8a05: > > snd_hda_codec_alc269 ehdaudio0D0: ALC245: picked fixup for PCI SSID 103c:8a05 > cs35l41-hda spi1-CSC3551:00-cs35l41-hda.0: CS35L41 Bound - SSID: 103C8A06 > > The existing entry therefore never applies here, the four CS35L41 > amplifiers on SPI are not registered and the internal speakers stay > silent. > > Add the same fixup that the 8a06 entry uses: the four amplifiers bind > and the speaker mute LED (codec GPIO 0x04) works. > > Signed-off-by: Michael Diesen > --- > v2: > - Resend using git send-email. v1 was mangled by my mail client (tabs > converted to spaces, long context lines soft-wrapped) so it could not > be applied with git am. Sorry for the noise, and thanks for the > pointer - I tested this one by mailing it to myself and applying it > with git am before sending. > - Use ALC245_FIXUP_CS35L41_SPI_4_HP_GPIO_LED instead of plain > ALC245_FIXUP_CS35L41_SPI_4. In v1 I claimed this was a non-2-in-1 SKU > that does not need the LED handling. That was wrong: DMI reports the > machine as "HP Dragonfly Folio G3 2-in-1", i.e. the same model as the > 8a06 entry, and the speaker mute LED stayed dark with plain SPI_4. > - Name the entry identically to the 8a06 one, as it is the same machine > with a different PCI SSID. > > On the mic-mute LED: alc285_fixup_hp_gpio_led() also drives GPIO 0x01 as > mic-mute LED. That LED does not respond on this unit. Poking the codec > GPIOs directly with hda-verb shows 0x04 toggling the speaker mute LED, > while neither 0x01 nor 0x02 has any effect, so the mic-mute LED does not > appear to be wired to the codec here. It does not work without the quirk > either, so this is no regression, and it matches what the 8a06 entry > already does - hence I kept the shared fixup instead of adding a new one. Thanks, applied now. Takashi