Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Ripeer <ripeeerr@gmail.com>
Cc: alsa-devel@alsa-project.org, perex@perex.cz
Subject: Re: [PATCH RFC] ALSA: hda/realtek: Add quirk for Lenovo Xiaoxin 14 GT
Date: Mon, 15 Jun 2026 09:31:48 +0200	[thread overview]
Message-ID: <87mrwwmf8b.wl-tiwai@suse.de> (raw)
In-Reply-To: <CANj20GgeB2y7jUrj43g1vP2_+u7awtecZCig0MxoJBJBM5=3ow@mail.gmail.com>

On Sat, 13 Jun 2026 18:46:07 +0200,
Ripeer wrote:
> 
> 
> From: ripeeerr@gmail.com
> 
> ALSA: hda/realtek: Add quirk for Lenovo Xiaoxin 14 GT
> 
> The Lenovo Xiaoxin 14 GT (Chinese market model, AMD Ryzen AI 9 365)
> produces constant electrical hissing and crackling noise from both
> internal speakers and 3.5mm headphone jack during audio playback.
> Audio works correctly on Windows. The noise is louder than the audio
> itself and is present on all tested distributions (Arch Linux, Fedora 44,
> kernels 6.12 and 7.0-zen).
> 
> The PCI SSID 17aa:3912 is not present in the quirk list. Additionally,
> in some configurations the BIOS reports the SSID as 17aa:0000, causing
> the kernel to apply no fixup at all:
> 
>   snd_hda_codec_alc269 hdaudioC1D0: ALC287: picked fixup for PCI SSID
> 17aa:0000
> 
> Codec info (/proc/asound/card1/codec#0):
>   Codec: Realtek ALC287
>   Vendor Id: 0x10ec0287
>   Subsystem Id: 0x17aa3912
>   Revision Id: 0x100002
> 
> Audio devices:
>   c2:00.1 AMD/ATI Radeon HD Audio [1002:1640]
>   c2:00.5 AMD Audio Coprocessor [1022:15e2]
>   c2:00.6 AMD Ryzen HD Audio Controller [1022:15e3]
> 
> GPIO state (all zeros, amplifier appears uninitialized):
>   IO[0-4]: enable=0, dir=0, data=0
> 
> The proposed fixup ALC287_FIXUP_YOGA9_14IAP7_BASS_SPK_PIN is chosen
> by analogy with neighboring Lenovo 14" AMD models (17aa:3911, 17aa:390d)
> that use the same fixup. However, this has NOT been verified by testing
> a compiled kernel — I do not currently have a working Linux installation
> on this machine. Guidance from maintainers on the correct fixup is
> very welcome.
> 
> Signed-off-by: ripeeerr@gmail.com
> ---
>  sound/hda/codecs/realtek/alc269.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/sound/hda/codecs/realtek/alc269.c b/sound/hda/codecs/realtek/
> alc269.c
> index dcbc66984..0d8f157c9 100644
> --- a/sound/hda/codecs/realtek/alc269.c
> +++ b/sound/hda/codecs/realtek/alc269.c
> @@ -7774,6 +7774,7 @@ static const struct hda_quirk alc269_fixup_tbl[] = {
>   SND_PCI_QUIRK(0x17aa, 0x390d, "Lenovo Yoga Pro 7 14ASP10",
> ALC287_FIXUP_YOGA9_14IAP7_BASS_SPK_PIN),
>   SND_PCI_QUIRK(0x17aa, 0x3911, "Lenovo Yoga Pro 7 14IAH10",
> ALC287_FIXUP_YOGA9_14IAP7_BASS_SPK_PIN),
> + SND_PCI_QUIRK(0x17aa, 0x3912, "Lenovo Xiaoxin 14 GT",
> ALC287_FIXUP_YOGA9_14IAP7_BASS_SPK_PIN),
>   SND_PCI_QUIRK(0x17aa, 0x3913, "Lenovo 145", ALC236_FIXUP_LENOVO_INV_DMIC),
>   SND_PCI_QUIRK(0x17aa, 0x391a, "Lenovo Yoga Slim 7 14AKP10",
> ALC287_FIXUP_YOGA9_14IAP7_BASS_SPK_PIN),

The code change looks OK, but the patch file isn't in an applicable
form -- likely your mailer broke the spaces and tabs.  At best, try to
submit via git-send-email.

Also, your Signed-off-by line should be properly formatted; it must be
with both your (real) name and mail address, as it's a legal
requirement.

Last but not least, please submit to linux-sound@vger.kernel.org for
the kernel patches.  alsa-devel ML is for user-space stuff.

So, please resubmit with the corrections of the above.


thanks,

Takashi

      reply	other threads:[~2026-06-15  7:32 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-13 16:46 [PATCH RFC] ALSA: hda/realtek: Add quirk for Lenovo Xiaoxin 14 GT Ripeer
2026-06-15  7:31 ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mrwwmf8b.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=perex@perex.cz \
    --cc=ripeeerr@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox