From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 82498C47258 for ; Tue, 23 Jan 2024 14:16:24 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id C87BBA4A; Tue, 23 Jan 2024 15:16:12 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz C87BBA4A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1706019382; bh=oEspfoFO05yzAviOiXySAnGDCi0hgKsktBv6RZDeiPc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=kLmOH2hMkTjAbqi3M95FlhYIApsCpQdlC43UL7QZDTPBeeBuegg0b4wzPuYh1E0Cu 9HMPZJBovz0kPQYu3cSTFTAbyRPMLiWDgksHiit0/5HTb7sfqHA20HM2pRpEiC4cmn 6HWCpRwPKQC2D6eghV/B2ZM/DjDQD31jBWEeeo/E= Received: by alsa1.perex.cz (Postfix, from userid 50401) id BA96CF805BE; Tue, 23 Jan 2024 15:15:09 +0100 (CET) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id EB0B7F805BD; Tue, 23 Jan 2024 15:15:08 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 752C3F8059F; Tue, 23 Jan 2024 15:15:01 +0100 (CET) Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 27E97F8057B for ; Tue, 23 Jan 2024 15:14:43 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 27E97F8057B Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=yPCkMcIT; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=WWVaL8YF; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=Iq56RTeh; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=YWPKdi8B Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id C55C21FD9D; Tue, 23 Jan 2024 14:14:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1706019282; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=48Zdgq+cJITCIoj+JZsjJPnJyJ76eCLaTzFd0e3VeAg=; b=yPCkMcITohU3QVF/WJYgaPODWAhe/Mwf4eKH8sUbuZ3UdBKP5jBkY6S64hS9TvRu7Kciuz RxErHR6H47VtzAPsoVqQvQcdvgi6kh81X7ncvI37+nDIxKiq0rRbKnGdwv9BuO3SJbiQbJ 3r4hqbDMEUO9SjqlaTLEgYG6J5Gydow= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1706019282; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=48Zdgq+cJITCIoj+JZsjJPnJyJ76eCLaTzFd0e3VeAg=; b=WWVaL8YFWaOi1tgIEwOz+nYmSt602SzQRhw6SYK5+O5BLrg1aPybe9qGA6z4SygCjNVvku rYSsZLttsMXH/bCg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1706019281; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=48Zdgq+cJITCIoj+JZsjJPnJyJ76eCLaTzFd0e3VeAg=; b=Iq56RTeh5BqrFqdLSxK+PNX6gINXzzjKmigNOBTPiAuzcREF1i6i/OrjqlkIbgl5X3lTB8 pDbIXYmgVj5NaXJ8EIr9fsrqZT4bAIt29QUP/vyiCqQDGRRDy/1/xUSZwFGHvxzgb9wqo/ 1nu502NwOChBEK20WEMa2ZcHjTg9BLg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1706019281; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=48Zdgq+cJITCIoj+JZsjJPnJyJ76eCLaTzFd0e3VeAg=; b=YWPKdi8BtQariZj8khsUp7R43IWseBWw9ru/ngy6cBdJZGMh0W5YZ31OPJxwniLBNVs7Ts aSyLleVDWMDva9Dg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id B4EF113786; Tue, 23 Jan 2024 14:14:41 +0000 (UTC) Received: from dovecot-director2.suse.de ([10.150.64.162]) by imap1.dmz-prg2.suse.org with ESMTPSA id HAenK9HJr2VtXgAAD6G6ig (envelope-from ); Tue, 23 Jan 2024 14:14:41 +0000 Date: Tue, 23 Jan 2024 15:14:41 +0100 Message-ID: <87mssw6sry.wl-tiwai@suse.de> From: Takashi Iwai To: Alexander Tsoy Cc: alsa-devel@alsa-project.org, Jaroslav Kysela Subject: Re: [PATCH] ALSA: usb-audio: Skip setting clock selector for single connections In-Reply-To: <20240123134635.54026-1-alexander@tsoy.me> References: <20240123134635.54026-1-alexander@tsoy.me> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Authentication-Results: smtp-out2.suse.de; none X-Spamd-Result: default: False [-1.97 / 50.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; RCVD_COUNT_THREE(0.00)[3]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; MID_CONTAINS_FROM(1.00)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_ALL(0.00)[]; BAYES_HAM(-2.87)[99.43%] Message-ID-Hash: W4YIHPEYASC4DFPQI7QPMSJ6TNPVETLE X-Message-ID-Hash: W4YIHPEYASC4DFPQI7QPMSJ6TNPVETLE X-MailFrom: tiwai@suse.de X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.9 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Tue, 23 Jan 2024 14:46:35 +0100, Alexander Tsoy wrote: > > Since commit 086b957cc17f5 ("ALSA: usb-audio: Skip the clock selector > inquiry for single connections") we are already skipping clock selector > inquiry if only one clock source is connected, but we are still sending > a set request. Lets skip that too. > > This should fix errors when setting a sample rate on devices that don't > have any controls present within the clock selector. An example of such > device is the new revision of MOTU M Series (07fd:000b): > > AudioControl Interface Descriptor: > bLength 8 > bDescriptorType 36 > bDescriptorSubtype 11 (CLOCK_SELECTOR) > bClockID 1 > bNrInPins 1 > baCSourceID(0) 2 > bmControls 0x00 > iClockSelector 0 > > Perhaps we also should check if clock selectors are readable and writeable > like we already do for clock sources, but this is out of scope of this > patch. > > Link: https://bugzilla.kernel.org/show_bug.cgi?id=217601 > Signed-off-by: Alexander Tsoy Thanks, applied. Takashi