From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8DE36C77B75 for ; Mon, 22 May 2023 07:23:03 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id BE6D7827; Mon, 22 May 2023 09:22:10 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz BE6D7827 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1684740180; bh=jGWSmm9gv7/pVW8niI5WePIe+zZc0wYiCQwetGTeemo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=sEPx9VyP1xsxBKAy/2VrAwA30cSRz1gt/e8CwJd+za1oimQLKXBuGu5o2FeNsFU6f 78lG365rFQ6o6MojRBUuFvaapFiqngLAV1W7glmAl1pJGDFS+wtk3y7YC1nu8uc7aI ae8JD1w4CGAlgsG9P+EZPJ6y9rjsYLYupzLJWJDs= Received: by alsa1.perex.cz (Postfix, from userid 50401) id A5B9DF80548; Mon, 22 May 2023 09:21:40 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id C9D77F8024E; Mon, 22 May 2023 09:21:39 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 6D010F8024E; Mon, 22 May 2023 09:21:36 +0200 (CEST) Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 6BDB8F80053 for ; Mon, 22 May 2023 09:21:33 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 6BDB8F80053 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=YYqPrN04; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=dMuYKASk Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id B89931FDAF; Mon, 22 May 2023 07:21:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1684740092; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fcpnjW2vqXIXtmdGf9iNyCE90YLY5sYWaK5RSd3g/nA=; b=YYqPrN04PSml0QeTXS+T4SeOEBEzCq32saDGEcqeQC9FVFMUuSRg0eSXjTvUT5Dae49oU3 hbvwooj5b9RDllB9dMeiqJQ749e32z2Ncihu1ZXNqGgn13l/oGBCXcdKymnGYSQ6nWt9K3 lx/vKfidcUXOxQWpq0uavNS4aDUVJwc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1684740092; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fcpnjW2vqXIXtmdGf9iNyCE90YLY5sYWaK5RSd3g/nA=; b=dMuYKASknN9uqvzt08LIArz6f5OlnQVVl9LgxjkHOgqHwV+qJvRu+iMue/HSWaBigt222V 22i0niDBjYOciuCQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 9A20013336; Mon, 22 May 2023 07:21:32 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id B2B3JPwXa2STMQAAMHmgww (envelope-from ); Mon, 22 May 2023 07:21:32 +0000 Date: Mon, 22 May 2023 09:21:32 +0200 Message-ID: <87mt1wygoz.wl-tiwai@suse.de> From: Takashi Iwai To: Jaroslav Kysela Cc: alsa-devel@alsa-project.org Subject: Re: [PATCH 03/36] ALSA: rawmidi: UMP support In-Reply-To: References: <20230519093114.28813-1-tiwai@suse.de> <20230519093114.28813-4-tiwai@suse.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Message-ID-Hash: ASFYXLAWPNPRXA4PFDRCMYFBNJMTXPHW X-Message-ID-Hash: ASFYXLAWPNPRXA4PFDRCMYFBNJMTXPHW X-MailFrom: tiwai@suse.de X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Mon, 22 May 2023 08:34:20 +0200, Jaroslav Kysela wrote: > > On 19. 05. 23 11:30, Takashi Iwai wrote: > > This patch adds the support helpers for UMP (Universal MIDI Packet) in > > ALSA core. > > > > The basic design is that a rawmidi instance is assigned to each UMP > > Endpoint. A UMP Endpoint provides a UMP stream, typically > > bidirectional (but can be also uni-directional, too), which may hold > > up to 16 UMP Groups, where each UMP (input/output) Group corresponds > > to the traditional MIDI I/O Endpoint. > > > > Additionally, the ALSA UMP abstraction provides the multiple UMP > > Blocks that can be assigned to each UMP Endpoint. A UMP Block is a > > metadata to hold the UMP Group clusters, and can represent the > > functions assigned to each UMP Group. A typical implementation of UMP > > Block is the Group Terminal Blocks of USB MIDI 2.0 specification. > > > > For distinguishing from the legacy byte-stream MIDI device, a new > > device "umpC*D*" will be created, instead of the standard (MIDI 1.0) > > devices "midiC*D*". The UMP instance can be identified by the new > > rawmidi info bit SNDRV_RAWMIDI_INFO_UMP, too. > > > > A UMP rawmidi device reads/writes only in 4-bytes words alignment, > > stored in CPU native endianness. > > > > The transmit and receive functions take care of the input/out data > > alignment, and may return zero or aligned size, and the params ioctl > > may return -EINVAL when the given input/output buffer size isn't > > aligned. > > > > A few new UMP-specific ioctls are added for obtaining the new UMP > > endpoint and block information. > > > > As of this commit, no ALSA sequencer instance is attached to UMP > > devices yet. They will be supported by later patches. > > > > Along with those changes, the protocol version for rawmidi is bumped > > to 2.0.3. > > > > Signed-off-by: Takashi Iwai > > Reviewed-by: Jaroslav Kysela > > except: > > > +/* UMP Endpoint information */ > > +struct snd_ump_endpoint_info { > > + int card; /* card number */ > > + int device; /* device number */ > > I suspect that those two fields were added to enumerate devices in the > control API. But this extension seems to be missing in your > patches. There is only SNDRV_CTL_IOCTL_UMP_NEXT_DEVICE > implemented. Otherwise those two fields are not useful. The SNDRV_CTL_IOCTL_UMP_NEXT_DEVICE is looping over rawmidi, and snd_rawmidi_info is provided for (kernel) UMP implementation. I took over those fields from snd_rawmidi_info, and they are supposed to be referred rather from sequencer clients/ports (as well as from the UMP rawmidi). Then it could be useful when a user-space sequencer client implements the UMP in future, and distinguish its identity. But, it's no big deal to drop those, too. thanks, Takashi