* [PATCH] ALSA: ymfpci: Use register macro in place of integer literal
@ 2023-03-29 4:39 Tasos Sahanidis via Alsa-devel
0 siblings, 0 replies; 2+ messages in thread
From: Tasos Sahanidis via Alsa-devel @ 2023-03-29 4:39 UTC (permalink / raw)
To: alsa-devel; +Cc: tiwai, tasos
[-- Attachment #0: Type: message/rfc822, Size: 4285 bytes --]
From: Tasos Sahanidis <tasos@tasossah.com>
To: alsa-devel@alsa-project.org
Cc: tiwai@suse.com, tasos@tasossah.com
Subject: [PATCH] ALSA: ymfpci: Use register macro in place of integer literal
Date: Wed, 29 Mar 2023 07:39:18 +0300
Message-ID: <20230329043918.179352-1-tasos@tasossah.com>
The macro for said register already exists, so just use it, to make the
code more readable.
Signed-off-by: Tasos Sahanidis <tasos@tasossah.com>
---
sound/pci/ymfpci/ymfpci_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/pci/ymfpci/ymfpci_main.c b/sound/pci/ymfpci/ymfpci_main.c
index 2858736ed..24378f6fd 100644
--- a/sound/pci/ymfpci/ymfpci_main.c
+++ b/sound/pci/ymfpci/ymfpci_main.c
@@ -2214,7 +2214,7 @@ static void snd_ymfpci_free(struct snd_card *card)
snd_ymfpci_free_gameport(chip);
- pci_write_config_word(chip->pci, 0x40, chip->old_legacy_ctrl);
+ pci_write_config_word(chip->pci, PCIR_DSXG_LEGACY, chip->old_legacy_ctrl);
release_firmware(chip->dsp_microcode);
release_firmware(chip->controller_microcode);
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ALSA: ymfpci: Use register macro in place of integer literal
[not found] <20230329043918.179352-1-tasos@tasossah.com>
@ 2023-03-29 6:41 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2023-03-29 6:41 UTC (permalink / raw)
To: Tasos Sahanidis; +Cc: alsa-devel, tiwai
On Wed, 29 Mar 2023 06:39:18 +0200,
Tasos Sahanidis wrote:
>
> The macro for said register already exists, so just use it, to make the
> code more readable.
>
> Signed-off-by: Tasos Sahanidis <tasos@tasossah.com>
Applied to for-next branch.
thanks,
Takashi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-03-29 6:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20230329043918.179352-1-tasos@tasossah.com>
2023-03-29 6:41 ` [PATCH] ALSA: ymfpci: Use register macro in place of integer literal Takashi Iwai
2023-03-29 4:39 Tasos Sahanidis via Alsa-devel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox