From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A4D4FC43334 for ; Tue, 14 Jun 2022 13:08:48 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id F1B37174C; Tue, 14 Jun 2022 15:07:55 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz F1B37174C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1655212126; bh=v1jT4QYHtal1M4uq6tlTR2PDjxY2CnqpTGOm4kX4lcg=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=q1d3qIQRWoewaZn+JD4Tx/919u5aQvnUOUbdBIF7DtbKe4GT8AL7McOhwI0G86J+a Dvs6DQqsOOCTbOFU9K3v2XL+ZbuC5C1XsS0SJSpfdFgi9SEHPKicT+tZSZYW+UxIV0 8Y/4Iq7HgwBYW1QK6X1Iu/pQSIT6SA/XK5dC+6aU= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 794ADF80137; Tue, 14 Jun 2022 15:07:55 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 14DEFF80139; Tue, 14 Jun 2022 15:07:54 +0200 (CEST) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id C9687F800D8 for ; Tue, 14 Jun 2022 15:07:47 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz C9687F800D8 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="nFU85tbC"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="nGmLT9eh" Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 3C9C921B2E; Tue, 14 Jun 2022 13:07:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1655212067; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=0aw/lt539XKKXxaepRRGF6X5TCusTY6Yl0rCv9i49iA=; b=nFU85tbCbcTo5QObwMGSo0ulv7kSuH58Rcb018z8b4Z1WbOHDAdVn29YVgKORy3EAQZYRh TBhY6OxzYY1HajuGtTs1QReEGFlstsCZ2xJc8EFCF+q8xkZOW9Fg79UbQ0RrHMgawVcUi7 RypSxKZjgxuQR1mXyL56DoAEnNhlDi8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1655212067; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=0aw/lt539XKKXxaepRRGF6X5TCusTY6Yl0rCv9i49iA=; b=nGmLT9ehMPJcKY8i5tiOnZVoyzuVhwgaaWKtt+uC0UkFg9vzpeWPU33O4kYjgdswVfEp/U tDyeINflQ3Rk19Ag== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 2823C1361C; Tue, 14 Jun 2022 13:07:47 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id vkZDCSOIqGLeHwAAMHmgww (envelope-from ); Tue, 14 Jun 2022 13:07:47 +0000 Date: Tue, 14 Jun 2022 15:07:46 +0200 Message-ID: <87o7yvpf4t.wl-tiwai@suse.de> From: Takashi Iwai To: Takashi Sakamoto Subject: Re: [PATCH] firewire: cdev: fix potential leak of kernel stack due to uninitialized value In-Reply-To: References: <20220512112037.103142-1-o-takashi@sakamocchi.jp> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Cc: alsa-devel@alsa-project.org, stefanr@s5r6.in-berlin.de, linux1394-devel@lists.sourceforge.net, Dan Carpenter X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Tue, 14 Jun 2022 14:30:36 +0200, Takashi Sakamoto wrote: > > Hi Iwai-san, > > I have a moderate request to you for the patch which fixes an issue > included in v5.19-rc1. If it's applicable and I can borrow your help > again, I'd like you to send the patch to mainline via your tree. Do you have the lore URL I can get a patch from? > If possible, it's preferable to apply additional three patches I > respined[1], but it could be optional since not so critical. > > [1] https://lore.kernel.org/alsa-devel/20220512111756.103008-1-o-takashi@sakamocchi.jp/ I can merge those, but now looking at the patches, I'm afraid that the patch 2 ("firewire: use struct_size over open coded arithmetic") is wrong; struct_size() takes the number of elements, and the element type is u32, hence you're allocating 4 times large data with that patch. thanks, Takashi