From: Robert Jarzmik <robert.jarzmik@free.fr>
To: Arnd Bergmann <arnd@arndb.de>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org, Vinod Koul <vinod.koul@intel.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Takashi Iwai <tiwai@suse.com>,
Haojian Zhuang <haojian.zhuang@gmail.com>,
Daniel Mack <daniel@zonque.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 14/15] ARM: pxa: change SSP devices allocation
Date: Sun, 08 Apr 2018 14:16:17 +0200 [thread overview]
Message-ID: <87o9it3nce.fsf@belgarion.home> (raw)
In-Reply-To: <CAK8P3a0xJnVfXfUtP+JXGNgc2-LuHUmZCMq-SnEQw3wu3azemA@mail.gmail.com> (Arnd Bergmann's message of "Thu, 5 Apr 2018 09:29:30 +0200")
Arnd Bergmann <arnd@arndb.de> writes:
> I don't know exactly how the probing works, but I'd assume that we have
> the correct device pointers in pxa2xx_ac97_dev_probe() and
> asoc_ssp_probe(), or maybe in pxa2xx_ac97_*_startup() and
> pxa_ssp_startup().
Yes, let's try this way, in the former patch
"ASoC: pxa: remove the dmaengine compat need" :
+++ b/sound/arm/pxa2xx-pcm-lib.c
@@ -126,7 +127,7 @@ int __pxa2xx_pcm_open(struct snd_pcm_substream *substream)
return ret;
return snd_dmaengine_pcm_open(
- substream, dma_request_slave_channel(rtd->platform->dev,
+ substream, dma_request_slave_channel(rtd->cpu_dai->dev,
dma_params->chan_name));
}
The cpu_dai device should be either pxa27x_ac97 or pxa-ssp-dai.<Id>, and amend
the dma slave map accordingly.
Cheers.
--
Robert
next prev parent reply other threads:[~2018-04-08 12:16 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-02 14:26 [PATCH 00/15] ARM: pxa: switch to DMA slave maps Robert Jarzmik
2018-04-02 14:26 ` [PATCH 01/15] dmaengine: pxa: use a dma slave map Robert Jarzmik
2018-04-02 14:26 ` [PATCH 02/15] ARM: pxa: add " Robert Jarzmik
2018-04-03 6:51 ` Arnd Bergmann
2018-04-03 15:18 ` Robert Jarzmik
2018-04-03 15:39 ` Arnd Bergmann
2018-04-02 14:26 ` [PATCH 03/15] mmc: pxamci: remove the dmaengine compat need Robert Jarzmik
2018-04-02 14:26 ` [PATCH 04/15] media: pxa_camera: " Robert Jarzmik
2018-04-22 11:06 ` Hans Verkuil
2018-05-04 19:29 ` Mauro Carvalho Chehab
2018-04-02 14:26 ` [PATCH 05/15] mtd: nand: pxa3xx: " Robert Jarzmik
2018-05-18 21:31 ` Daniel Mack
2018-05-23 21:54 ` Daniel Mack
2018-04-02 14:26 ` [PATCH 06/15] net: smc911x: " Robert Jarzmik
2018-04-02 14:26 ` [PATCH 07/15] net: smc91x: " Robert Jarzmik
2018-04-02 14:26 ` [PATCH 08/15] ASoC: pxa: " Robert Jarzmik
2018-04-12 15:26 ` Mark Brown
2018-04-12 16:55 ` Robert Jarzmik
2018-04-02 14:26 ` [PATCH 09/15] net: irda: pxaficp_ir: " Robert Jarzmik
2018-04-23 8:37 ` Greg Kroah-Hartman
2018-04-02 14:26 ` [PATCH 10/15] ata: pata_pxa: " Robert Jarzmik
2018-04-02 14:26 ` [PATCH 11/15] dmaengine: pxa: document pxad_param Robert Jarzmik
2018-04-02 14:26 ` [PATCH 12/15] dmaengine: pxa: make the filter function internal Robert Jarzmik
2018-04-02 16:25 ` kbuild test robot
2018-04-02 16:35 ` kbuild test robot
2018-04-03 7:13 ` Arnd Bergmann
2018-04-02 14:26 ` [PATCH 13/15] ARM: pxa: remove the DMA IO resources Robert Jarzmik
2018-04-02 14:26 ` [PATCH 14/15] ARM: pxa: change SSP devices allocation Robert Jarzmik
2018-04-03 7:06 ` Arnd Bergmann
2018-04-03 15:32 ` Robert Jarzmik
2018-04-03 15:53 ` Arnd Bergmann
2018-04-05 6:51 ` Robert Jarzmik
2018-04-05 7:29 ` Arnd Bergmann
2018-04-08 12:16 ` Robert Jarzmik [this message]
2018-04-02 14:26 ` [PATCH 15/15] ARM: pxa: change SSP DMA channels allocation Robert Jarzmik
2018-04-02 18:46 ` kbuild test robot
2018-04-03 7:15 ` [PATCH 00/15] ARM: pxa: switch to DMA slave maps Arnd Bergmann
2018-04-03 15:08 ` Ulf Hansson
2018-04-04 19:49 ` Robert Jarzmik
2018-04-04 19:56 ` Boris Brezillon
2018-04-05 6:29 ` Ulf Hansson
2018-04-05 6:50 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o9it3nce.fsf@belgarion.home \
--to=robert.jarzmik@free.fr \
--cc=alsa-devel@alsa-project.org \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=daniel@zonque.org \
--cc=haojian.zhuang@gmail.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tiwai@suse.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).