From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kuninori Morimoto Subject: Re: [PATCH v2] ASoC: simple-card: cpu_dai_name creates confusion when DT case Date: Thu, 27 Feb 2014 20:31:45 -0800 (PST) Message-ID: <87ob1r97td.wl%kuninori.morimoto.gx@gmail.com> References: <87eh2r9169.wl%kuninori.morimoto.gx@gmail.com> <20140227050726.GR9383@sirena.org.uk> <87ios0etzw.wl%kuninori.morimoto.gx@gmail.com> <87ppm87z3i.wl%kuninori.morimoto.gx@gmail.com> <20140228035357.GL9383@sirena.org.uk> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-pb0-f43.google.com (mail-pb0-f43.google.com [209.85.160.43]) by alsa0.perex.cz (Postfix) with ESMTP id AB2B7261A27 for ; Fri, 28 Feb 2014 05:31:48 +0100 (CET) Received: by mail-pb0-f43.google.com with SMTP id um1so223571pbc.16 for ; Thu, 27 Feb 2014 20:31:46 -0800 (PST) In-Reply-To: <20140228035357.GL9383@sirena.org.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Mark Brown Cc: Linux-ALSA , Simon , Liam Girdwood , Kuninori Morimoto List-Id: alsa-devel@alsa-project.org Hi Mark > > + * see > > + * fmt_single_name() > > + * fmt_multiple_name() > > + */ > > + dai_link->cpu_dai_name = NULL; > > + > > Why do this by overwriting rather than at the point where the variable > gets assigned? Do you mean why I did it end of asoc_simple_card_parse_of() ? Because this cpu_dai_name itself is used for dai_link->name, dai_link->stream_name; This patch set NULL after that.