Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
Cc: alsa-devel@alsa-project.org, Jaroslav Kysela <perex@perex.cz>,
	Manuel Lauss <mano@roarinelk.homelinux.net>
Subject: Re: [PATCH] ALSA: soc/au1x: declare that FIFO is reported in frames
Date: Mon, 01 Apr 2024 12:52:29 +0200	[thread overview]
Message-ID: <87plv95p8y.wl-tiwai@suse.de> (raw)
In-Reply-To: <20240401101339.506639-1-oswald.buddenhagen@gmx.de>

On Mon, 01 Apr 2024 12:13:39 +0200,
Oswald Buddenhagen wrote:
> 
> Signed-off-by: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
> ---
> 
> Is this right? The comment on the field says "fifo entries of AC97/I2S
> PSC", which suggests frames, but that may mean whatever.
> 
> Cc: Manuel Lauss <mano@roarinelk.homelinux.net>

Use a right subject prefix (ASoC in this case) and put the
corresponding maintainers to Cc.


thanks,

Takashi

> ---
>  sound/soc/au1x/dbdma2.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/sound/soc/au1x/dbdma2.c b/sound/soc/au1x/dbdma2.c
> index ea01d6490cec..2c8c01a5fb8f 100644
> --- a/sound/soc/au1x/dbdma2.c
> +++ b/sound/soc/au1x/dbdma2.c
> @@ -66,7 +66,8 @@ struct au1xpsc_audio_dmadata {
>  /* PCM hardware DMA capabilities - platform specific */
>  static const struct snd_pcm_hardware au1xpsc_pcm_hardware = {
>  	.info		  = SNDRV_PCM_INFO_MMAP | SNDRV_PCM_INFO_MMAP_VALID |
> -			    SNDRV_PCM_INFO_INTERLEAVED | SNDRV_PCM_INFO_BATCH,
> +			    SNDRV_PCM_INFO_INTERLEAVED | SNDRV_PCM_INFO_BATCH |
> +			    SNDRV_PCM_INFO_FIFO_IN_FRAMES,
>  	.period_bytes_min = AU1XPSC_PERIOD_MIN_BYTES,
>  	.period_bytes_max = 4096 * 1024 - 1,
>  	.periods_min	  = 2,
> --
> 2.42.0.419.g70bf8a5751
> 

      reply	other threads:[~2024-04-01 10:53 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-01 10:13 [PATCH] ALSA: soc/au1x: declare that FIFO is reported in frames Oswald Buddenhagen
2024-04-01 10:52 ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87plv95p8y.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=mano@roarinelk.homelinux.net \
    --cc=oswald.buddenhagen@gmx.de \
    --cc=perex@perex.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox