From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 92184C77B60 for ; Sun, 23 Apr 2023 14:31:41 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 792CFF0E; Sun, 23 Apr 2023 16:30:48 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 792CFF0E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1682260298; bh=rZM4uMFYmv6i77nrXW9ho4+CRjeRKmqWcK/ZJiDwP5s=; h=Date:From:To:Subject:In-Reply-To:References:CC:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=pePMdq/gfjFB/HtL6iusVD7fcUzNwqmihDSvwZN3YNR2GxsxMN7YFvYLV4/2cbDYf IthncaI5QzOZpgQhjraCkwE9Vb3Zq4pT+ev18VybQ2hx40zCbBqKDraWzoav/5UOoo mZsHAFsZbJDZtEy8l8ylFedwAuL5Z1BC2Ch/eNog= Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 0963EF80236; Sun, 23 Apr 2023 16:30:23 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 9DCFFF80236; Sun, 23 Apr 2023 16:30:17 +0200 (CEST) Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 86F1AF80137 for ; Sun, 23 Apr 2023 16:30:07 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 86F1AF80137 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=M1geHF1l; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=47ZdJDrS Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 1A6671F8C8; Sun, 23 Apr 2023 14:30:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1682260206; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=3ZODwOgOj5HnKOQXzSnxjQoXRTlYWXn/6Pt7HYrPD00=; b=M1geHF1lrM5Jp7D4e3IczNXtjA/IVLeO7wKZU4IxCRd/05oSU5Q86aRWKI82wsUhcaiSIE gzquv8DtwsMZNYM6/wHLBigJML6lLppNFvjNnexz2vk2jjQigHL7PVGRyCSpI7GyqkvlQi wXslNGRvTCKSO0J6XLunzM9t4jr64vE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1682260206; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=3ZODwOgOj5HnKOQXzSnxjQoXRTlYWXn/6Pt7HYrPD00=; b=47ZdJDrSFyXFStTW1NqndJGyFsbt1UBNXdzr1K3j49D51cHMzzjH9l3imF8FGbKsxsR02m KiH0dYKHv4BewMAw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id F2A4913498; Sun, 23 Apr 2023 14:30:05 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id iv45Ou1ARWTxRQAAMHmgww (envelope-from ); Sun, 23 Apr 2023 14:30:05 +0000 Date: Sun, 23 Apr 2023 16:30:05 +0200 Message-ID: <87pm7uoemq.wl-tiwai@suse.de> From: Takashi Iwai To: Oswald Buddenhagen Subject: Re: [PATCH 2/2] ALSA: emu10k1: use high-level I/O in set_filterQ() In-Reply-To: References: <87y1mjnj8t.wl-tiwai@suse.de> <878rejoya4.wl-tiwai@suse.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Message-ID-Hash: 23DFKHYPS64V7KIKIC62ECL5YDZYOZER X-Message-ID-Hash: 23DFKHYPS64V7KIKIC62ECL5YDZYOZER X-MailFrom: tiwai@suse.de X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: alsa-devel@alsa-project.org X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Sun, 23 Apr 2023 10:51:38 +0200, Oswald Buddenhagen wrote: > > On Sun, Apr 23, 2023 at 09:25:39AM +0200, Takashi Iwai wrote: > > Again, you must have a bit more say here... > > For example, you didn't write why this change is needed. > > You thought it obvious? No, readers don't know. > > > it is obvious from the patch - the code becomes much shorter and more > legible. It's not obvious unless you read the code changes. Not obvious whether it's a code refactoring without any functional change, etc. Such info can be well put in the patch description. > and someone who just reads the log/blame wouldn't care, > because it doesn't actually explain anything. but whatever. Someone already cared. See? > On Sun, Apr 23, 2023 at 09:35:46AM +0200, Takashi Iwai wrote: > > On Sat, 22 Apr 2023 18:10:20 +0200, > > Oswald Buddenhagen wrote: > >> > >> ... and also use more pre-defined constants on the way (some of which > >> required adjustment). > >> > >> Signed-off-by: Oswald Buddenhagen > > > > Applied this one, but skipped the patch 2. > > > which is funny, because that commit message misses the obvious "why" > part as well - it just mentions an additional thing that is unique to > this patch. > > so to be consistent, you should reject both patches and wait for an > update. Right, it was enough for me to reply the same thing again, so I wanted just to reduce the pile of XXXX. I'd reject all at the next time :) > > BTW, it would be really better if we define some macro for the > > highlevel I/O definition. It's cumbersome to decode and check > > manually at review whether the conversion is correct, and it's > > error-prone. > > > yes, i considered that. > i also considered many more refactorings, and had to hold myself back - > there are enough nice-to-have patches in this series as-is. > i mean, 15 years ago it would have made sense to go crazy, but now the > hardware is a bit too obsolete to go much beyond what i actually need > for my project. i'm assuming some people outside the western sphere > are still using our scrap with linux, but we rarely hear from them, so > it's hard to know ... Yeah, that's a dilemma of maintaining the old legacy stuff. Takashi