From: Eric Anholt <eric@anholt.net>
To: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Florian Fainelli <f.fainelli@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
kernel@martin.sperl.org, Matthias Reichl <hias@horus.com>,
phil@raspberrypi.org
Cc: Stefan Wahren <stefan.wahren@i2se.com>,
alsa-devel@alsa-project.org,
linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH V2] ARM: dts: bcm283x: Fix probing of bcm2835-i2s
Date: Wed, 06 Dec 2017 13:53:42 -0800 [thread overview]
Message-ID: <87po7rr09l.fsf@anholt.net> (raw)
In-Reply-To: <1511717111-6055-1-git-send-email-stefan.wahren@i2se.com>
[-- Attachment #1.1: Type: text/plain, Size: 815 bytes --]
Stefan Wahren <stefan.wahren@i2se.com> writes:
> Since 517e7a1537a ("ASoC: bcm2835: move to use the clock framework")
> the bcm2835-i2s requires a clock as DT property. Unfortunately
> the necessary DT change has never been applied. While we are at it
> also fix the first PCM register range to cover the PCM_GRAY register.
>
> This patch also fixes the dt-bindings accordlingly.
>
> Fixes: 517e7a1537a ("ASoC: bcm2835: move to use the clock framework")
> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
> Reviewed-by: Eric Anholt <eric@anholt.net>
> Tested-by: Matthias Reichl <hias@horus.com>
DT folks, are you happy with the binding change here? It fixes having
the i2s node also map a very separate hardware block (clocks) which has
its own DT node.
The I2S node is disabled in the upstream DT files.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
prev parent reply other threads:[~2017-12-06 21:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-26 17:25 [PATCH V2] ARM: dts: bcm283x: Fix probing of bcm2835-i2s Stefan Wahren
2017-12-06 21:53 ` Eric Anholt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87po7rr09l.fsf@anholt.net \
--to=eric@anholt.net \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=f.fainelli@gmail.com \
--cc=hias@horus.com \
--cc=kernel@martin.sperl.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=phil@raspberrypi.org \
--cc=robh+dt@kernel.org \
--cc=stefan.wahren@i2se.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox