From: Takashi Iwai <tiwai@suse.de>
To: "edmund.raile" <edmund.raile@proton.me>
Cc: alsa-devel@alsa-project.org, stable@vger.kernel.org,
regressions@lists.linux.dev, o-takashi@sakamocchi.jp,
gustavoars@kernel.org, clemens@ladisch.de,
linux-sound@vger.kernel.org
Subject: Re: [REGRESSION] ALSA: firewire-lib: heavy digital distortion with Fireface 800
Date: Thu, 25 Jul 2024 15:07:40 +0200 [thread overview]
Message-ID: <87r0bhipr7.wl-tiwai@suse.de> (raw)
In-Reply-To: <rrufondjeynlkx2lniot26ablsltnynfaq2gnqvbiso7ds32il@qk4r6xps7jh2>
On Thu, 25 Jul 2024 00:24:29 +0200,
edmund.raile wrote:
>
> Bisection revealed that the bitcrushing distortion with RME FireFace 800
> was caused by 1d717123bb1a7555
> ("ALSA: firewire-lib: Avoid -Wflex-array-member-not-at-end warning").
>
> Reverting this commit yields restoration of clear audio output.
> I will send in a patch reverting this commit for now, soonTM.
>
> #regzbot introduced: 1d717123bb1a7555
While it's OK to have a quick revert, it'd be worth to investigate
further what broke there; the change is rather trivial, so it might be
something in the macro expansion or a use of flex array stuff.
thanks,
Takashi
next prev parent reply other threads:[~2024-07-25 13:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-24 22:24 [REGRESSION] ALSA: firewire-lib: heavy digital distortion with Fireface 800 edmund.raile
2024-07-25 13:07 ` Takashi Iwai [this message]
2024-07-25 14:08 ` Gustavo A. R. Silva
2024-07-25 15:06 ` Takashi Sakamoto
2024-07-25 15:11 ` Gustavo A. R. Silva
2024-07-25 15:38 ` Takashi Iwai
2024-07-25 15:48 ` Gustavo A. R. Silva
-- strict thread matches above, loose matches on Subject: below --
2024-07-18 12:29 edmund.raile
2024-08-20 12:24 ` Takashi Sakamoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r0bhipr7.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=clemens@ladisch.de \
--cc=edmund.raile@proton.me \
--cc=gustavoars@kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=o-takashi@sakamocchi.jp \
--cc=regressions@lists.linux.dev \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox