From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 81106C07CB1 for ; Mon, 27 Nov 2023 16:22:27 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 09126BC0; Mon, 27 Nov 2023 17:22:10 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 09126BC0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1701102140; bh=d0hfk6ggxJROj7Nk12gdiGlwJhNqr7RjKiRUrRDBdGA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=eQ4rzY6o+Dn9syFKZSywNPHuwTyhUzuI+7xK+bRHWT0nCVrTVyKncT4t3+RcwcupO wxnQC9mcYztgMiQ59JuEO7fJkdyCCeaW5B38YovcXYYHDHTCILsTkAqG8lOrtg3Q2e bPkWQhpHbKxWnnjPcBEbF6/mH3hd7hXffUI7eeG4= Received: by alsa1.perex.cz (Postfix, from userid 50401) id D8B80F8057A; Mon, 27 Nov 2023 17:21:48 +0100 (CET) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 431A9F80588; Mon, 27 Nov 2023 17:21:48 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 4B4A1F8016E; Mon, 27 Nov 2023 17:21:45 +0100 (CET) Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2a07:de40:b251:101:10:150:64:2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 852E4F800F5 for ; Mon, 27 Nov 2023 17:21:41 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 852E4F800F5 Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id DD2D81FC07; Mon, 27 Nov 2023 16:21:40 +0000 (UTC) Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 9AFCB1379A; Mon, 27 Nov 2023 16:21:40 +0000 (UTC) Received: from dovecot-director2.suse.de ([10.150.64.162]) by imap1.dmz-prg2.suse.org with ESMTPSA id 1m9kJBTCZGWDWQAAD6G6ig (envelope-from ); Mon, 27 Nov 2023 16:21:40 +0000 Date: Mon, 27 Nov 2023 17:21:40 +0100 Message-ID: <87r0kbnp4b.wl-tiwai@suse.de> From: Takashi Iwai To: Peter Ujfalusi Cc: perex@perex.cz, tiwai@suse.com, alsa-devel@alsa-project.org, linux-sound@vger.kernel.org, pierre-louis.bossart@linux.intel.com, kai.vehmanen@linux.intel.com, ranjani.sridharan@linux.intel.com Subject: Re: [PATCH] ALSA: hda: intel-nhlt: Ignore vbps when looking for DMIC 32 bps format In-Reply-To: <20231127111658.17275-1-peter.ujfalusi@linux.intel.com> References: <20231127111658.17275-1-peter.ujfalusi@linux.intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Authentication-Results: smtp-out2.suse.de; none X-Rspamd-Server: rspamd2 X-Spamd-Result: default: False [-4.00 / 50.00]; REPLY(-4.00)[] X-Rspamd-Queue-Id: DD2D81FC07 Message-ID-Hash: J4ATAAWKN6PO4LD7CTA6GMNYNVKS2S3A X-Message-ID-Hash: J4ATAAWKN6PO4LD7CTA6GMNYNVKS2S3A X-MailFrom: tiwai@suse.de X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.9 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Mon, 27 Nov 2023 12:16:58 +0100, Peter Ujfalusi wrote: > > When looking up DMIC blob from the NHLT table and the format is 32 bits, > ignore the vbps matching for 32 bps for DMIC since some NHLT table have > the vbps as 24, some have it as 32. > The DMIC hardware supports only one type of 32 bit sample size, which is > 24 bit sampling on the MSB side and bits[1:0] is used for indicating the > channel number. > > Signed-off-by: Peter Ujfalusi > Reviewed-by: Kai Vehmanen > Reviewed-by: Pierre-Louis Bossart > Reviewed-by: Ranjani Sridharan Thanks, applied now to for-linus branch. Takashi