From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AFFF5C7EE23 for ; Thu, 18 May 2023 14:58:42 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 682DB209; Thu, 18 May 2023 16:57:49 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 682DB209 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1684421919; bh=nCsWkhWlnzMdWjZhUF+rYH/YBW5NVbLgd/3P24TZF6A=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=ie9RWH2eAuIMYllNwpXuGWovQRBc1z1MIh01Hrr0f4A3D6zShLFPpEoxVai4l7DOp jBMmMqF1ywqH5BaaivzLMgtW8JGWimXrISkT+Bw+WOijZQKtv5H1pRxphRBpmNubIY 8PvM2QXjmAvcKWdLcTFqqhAh+/b83K/cOdVXgr2o= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 20E30F80272; Thu, 18 May 2023 16:57:15 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id C8FB0F80272; Thu, 18 May 2023 16:57:14 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id A6429F80272; Thu, 18 May 2023 16:57:11 +0200 (CEST) Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id E1B4AF8016D for ; Thu, 18 May 2023 16:57:08 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz E1B4AF8016D Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=MKFzxuww; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=BXfJ+KCd Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 5A23722406; Thu, 18 May 2023 14:57:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1684421828; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ccgxGB2846YVnfDxSiQgZuTZf39KdglyYwc4Q2Ei8H0=; b=MKFzxuwwBmPRfEbb2J/3YmT68WMmXtwFd7K3hvB+aedqMg+vdXSqTdRA3b6dOpuLc/Wbxc 2leKjWjJ+wdh3s6HbC2E0tEqN0AdIfgdwCFGgD8s2DbrgL1Ef9d7E8Y/A15W8NRFUrV70c 8M+H9QmXxRCixGNwGdI0CKSNzUAXcjY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1684421828; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ccgxGB2846YVnfDxSiQgZuTZf39KdglyYwc4Q2Ei8H0=; b=BXfJ+KCdi5/Lg+gGR4A5D0DY4MKU4JMoYQPexbjinRyBNxY865rcakBo3MgDWpUk9VSS0T v6ugF0s2gC63LiBQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 1D7001390B; Thu, 18 May 2023 14:57:08 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id ql/LBMQ8ZmQIaAAAMHmgww (envelope-from ); Thu, 18 May 2023 14:57:08 +0000 Date: Thu, 18 May 2023 16:57:07 +0200 Message-ID: <87r0rdhem4.wl-tiwai@suse.de> From: Takashi Iwai To: Oswald Buddenhagen Cc: alsa-devel@alsa-project.org, Jaroslav Kysela Subject: Re: [PATCH 1/2] ALSA: emu10k1: fix synthesizer sample playback position and caching In-Reply-To: <20230518140339.3722308-1-oswald.buddenhagen@gmx.de> References: <20230518140339.3722308-1-oswald.buddenhagen@gmx.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Message-ID-Hash: RLD2JWWZTWS446QZ6O3OJ7F4L2BIB65X X-Message-ID-Hash: RLD2JWWZTWS446QZ6O3OJ7F4L2BIB65X X-MailFrom: tiwai@suse.de X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu, 18 May 2023 16:03:38 +0200, Oswald Buddenhagen wrote: > > Compensate for the cache delay, and actually populate the cache. > Without these, the playback would start with garbage (which would be > (mostly?) masqueraded by the attack phase). > > Unlike for the PCM voices, this doesn't try to compensate for the > interpolator read-ahead, because it's pointless to be super-exact here. > > Note that this code is probably still broken for particularly short > samples, because we ignore the loop-related parts of CCR. But I'm not > going to reverse-engineer that now ... > > Signed-off-by: Oswald Buddenhagen Applied both patches now. Thanks. Takashi