From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 44E87C77B76 for ; Fri, 21 Apr 2023 14:58:20 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 22D6DE8F; Fri, 21 Apr 2023 16:57:28 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 22D6DE8F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1682089098; bh=/XeR2n1kB0dgvqHpzYaea3U+m4sw33iWWc+4bGDH11w=; h=Date:From:To:Subject:In-Reply-To:References:CC:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=OtfEamc5AvRq/cl6wlkrSAzrrYp/lpGCEWTZ6P0IQOQe7iUcfhzk3nHMFaVq4Lh1A vKDvmUnmrTl0B1jdiKut22Is6a/fLT2O/ruytA5moTnH/q+bzekQHQcXwVKdHrOkT6 ooVeOgPB8LYhCBu5wIG3bTN9lqMwRM/5hKJ9p7ts= Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 269A6F80155; Fri, 21 Apr 2023 16:57:03 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 42460F80155; Fri, 21 Apr 2023 16:56:59 +0200 (CEST) Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id A6179F80053 for ; Fri, 21 Apr 2023 16:56:53 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz A6179F80053 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=xCHJvte3; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=qeSdWW05 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 8405F1FDDF; Fri, 21 Apr 2023 14:56:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1682089013; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=qjPSqdBltSU+pYXo7XTfNzm4yCsrx/BaRQUAVuOSzVw=; b=xCHJvte3CGy+o/+5P5R+gOiMYGD2kWQ2G37wmyeU46T3n5sDOOBBLTDl4Rry3WHdAqRRx4 hTi4SfKUtr/1D9SLpVXUXrrguEwxh5ssxwKptlUpCQKjWZXo0URCupQ9VphMPXyeAOdhb7 xESd9vowFaESy+uNOfcUnQ/KNxc9hf4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1682089013; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=qjPSqdBltSU+pYXo7XTfNzm4yCsrx/BaRQUAVuOSzVw=; b=qeSdWW05OWtaLyZck6D6JJLvqS5I4pbNqDrF+c8q6XPTcf/iy+aA/QAGH6GPcbFwizHSzn GOXQ02j68jOdExAQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 6245E1390E; Fri, 21 Apr 2023 14:56:53 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 35GcFjWkQmThCwAAMHmgww (envelope-from ); Fri, 21 Apr 2023 14:56:53 +0000 Date: Fri, 21 Apr 2023 16:56:52 +0200 Message-ID: <87r0sdqo5n.wl-tiwai@suse.de> From: Takashi Iwai To: Oswald Buddenhagen Subject: Re: [PATCH 1/7] ALSA: emu10k1: drop redundant snd_emu10k1_efx_playback_hw_free() In-Reply-To: <20230421141006.1005452-1-oswald.buddenhagen@gmx.de> References: <20230421141006.1005452-1-oswald.buddenhagen@gmx.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Message-ID-Hash: DANI2EPPMIGDTXGIZ3KTGK77MHXZ7ESJ X-Message-ID-Hash: DANI2EPPMIGDTXGIZ3KTGK77MHXZ7ESJ X-MailFrom: tiwai@suse.de X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: alsa-devel@alsa-project.org X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri, 21 Apr 2023 16:10:00 +0200, Oswald Buddenhagen wrote: > > Or actually, replace snd_emu10k1_playback_hw_free() with it, as that is > a subset. > > Signed-off-by: Oswald Buddenhagen The code changes in the whole patch series look OK, but still a few minor corrections in the change logs (missing commit summary, etc) are needed. Also, when you submit this size of patch series, please make a cover letter and explain what the series are intended. thanks, Takashi