From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D6253C38142 for ; Tue, 31 Jan 2023 08:35:51 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id D169DDF3; Tue, 31 Jan 2023 09:34:59 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz D169DDF3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1675154149; bh=nHXnU+9XDfYF2OnuuJ6EDljcNQ7qa+HitfCkvqK2v+o=; h=Date:From:To:Subject:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=TI/TKkTO1XQx4rHWRh01GoI9vP1FxPvO2zBOLGZiA1M71A3QtCCvAC8IXhwarK8Pi Gixtb8sYKWDCEtmRxy5GasW59mbRUkaC26XokZfW7R9Lo1YU7dJ3gBjaET35GRw9/B lAQy9znRIomOY6PLGxXaSDuDnmaM5zfGtrTyxpVU= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 0A56FF80245; Tue, 31 Jan 2023 09:34:58 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id EF584F800A7; Tue, 31 Jan 2023 09:34:56 +0100 (CET) Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 4B6C3F800A7 for ; Tue, 31 Jan 2023 09:34:51 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 4B6C3F800A7 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=c8XJcfI0; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=7p5WJJTp Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id A00952043F; Tue, 31 Jan 2023 08:34:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1675154091; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=OaZFrQIRLxMBN8GalJDihMwDhfB7pdrWRt2BYXcozeg=; b=c8XJcfI0ngoQWUtK0Rg/9J7YE19ccNBLiq0pm6nKq6Ue+LnT6erzC3SFgOVcsTIZC9LvP0 calfW9h1IoiNrxdZv9YkF9C0tLJ46v4WWqLBsbuNc/LAPLRILYAsfEYBrQV8NME9MPCA29 nFfsF3mhB8yr34lbWOCJqgYXRjnnwq0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1675154091; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=OaZFrQIRLxMBN8GalJDihMwDhfB7pdrWRt2BYXcozeg=; b=7p5WJJTpyqqOAjZtLcNS88AGynr42EW8Ow4uoH/uGyBslyJWLdBBu/Qjs5Fi5jBKIIC5DS st12tEun8z+vebBw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 8778413585; Tue, 31 Jan 2023 08:34:51 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id IUtpIKvS2GN9GgAAMHmgww (envelope-from ); Tue, 31 Jan 2023 08:34:51 +0000 Date: Tue, 31 Jan 2023 09:34:51 +0100 Message-ID: <87r0vbp0es.wl-tiwai@suse.de> From: Takashi Iwai To: Takashi Sakamoto Subject: Re: [PATCH] ALSA: firewire-motu: fix unreleased lock warning in hwdep device In-Reply-To: <20230130141540.102854-1-o-takashi@sakamocchi.jp> References: <20230130141540.102854-1-o-takashi@sakamocchi.jp> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alsa-devel@alsa-project.org, Dan Carpenter Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Mon, 30 Jan 2023 15:15:40 +0100, Takashi Sakamoto wrote: > > Smatch static analysis tool detects that acquired lock is not released > in hwdep device when condition branch is passed due to no event. It is > unlikely to occur, while fulfilling is preferable for better coding. > > Reported-by: Dan Carpenter > Fixes: 634ec0b2906e ("ALSA: firewire-motu: notify event for parameter change in register DSP model") > Signed-off-by: Takashi Sakamoto Applied now. Thanks. Takashi