From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5305AC5478C for ; Fri, 23 Feb 2024 13:58:31 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 67E7E826; Fri, 23 Feb 2024 14:58:19 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 67E7E826 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1708696709; bh=xaO4cUScFrSD4pTs/VF4FjHkzV69WCYv1eyYZyogaag=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=jSN4Ag/9Khjw2Kek85jMerp2OMMX7hJUrOXi8PcZdl3btHHX8H7Nt6zyFsDVMGVwn koSXMBdjZ2lrSM+wkHdAhVPtS+a5LTUJVn/m9F8SX16MAeTFwC5xpprSVKqxEUAx+w /7QLp30m9f2iFfun3sdzQgw7dC/ZHfSRR6bHZCI8= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 8F79DF805A8; Fri, 23 Feb 2024 14:57:55 +0100 (CET) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id E8894F805AA; Fri, 23 Feb 2024 14:57:54 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 0A6D9F80496; Fri, 23 Feb 2024 14:57:49 +0100 (CET) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 90849F800EE for ; Fri, 23 Feb 2024 14:57:44 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 90849F800EE Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=BplvIKk+; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=6BUBAebZ; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=UDw2Hkg/; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=NsPt6L+L Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id EB59D21228; Fri, 23 Feb 2024 13:57:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1708696664; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=V2VnXiwBMr8OEGNfOOEISrIRVqyNDwzg6Yi1yiJ6y0k=; b=BplvIKk+ejYyXBCvNq3pwruGLaaPmqdSTY672Ro0Z2fHVuHO3PHMVBGbflUa3RaLTjx5U5 dp57nWhedA5bCpLe5CdP/K3rMv5u/XrZWU1AnIKbgcqDcfDuFTLN5/fplwHn83Qe4UzylK 7Fy/GD+IZISbuMmPlhpONAa5G3ww2FU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1708696664; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=V2VnXiwBMr8OEGNfOOEISrIRVqyNDwzg6Yi1yiJ6y0k=; b=6BUBAebZ6+9gidjUaXigSgp3mYqrqFZkq5uNE4/Z+xB1eG99ih36C5W4kiJ4l3rVTmdMnj MtdNPveetwF/MAAw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1708696663; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=V2VnXiwBMr8OEGNfOOEISrIRVqyNDwzg6Yi1yiJ6y0k=; b=UDw2Hkg/L+Gn0/o/DaJP2u5bkdWaWfXqX3Sjryb4hPilgT5aTF2zungS3bWHejOuU4FtcM eykc4d/nyjieflb+eTVbaCgQHeI7c2U9Nyd2/8Oe4hB/XgYv14MwsYsdxveP0SKRO6+BYP iGxYTWoSEJZRLBkBsTSqKkEjUt1kM3k= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1708696663; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=V2VnXiwBMr8OEGNfOOEISrIRVqyNDwzg6Yi1yiJ6y0k=; b=NsPt6L+L3H8lwvCuJ/eFnghQ3Y3WyLMpOTV6bcJ9tsLa+px1PUP6NVgF5cI80Tef1JCxyO miy7s1nigjDq2CBg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id C6875132C7; Fri, 23 Feb 2024 13:57:43 +0000 (UTC) Received: from dovecot-director2.suse.de ([10.150.64.162]) by imap1.dmz-prg2.suse.org with ESMTPSA id +WXyLlek2GUnDAAAD6G6ig (envelope-from ); Fri, 23 Feb 2024 13:57:43 +0000 Date: Fri, 23 Feb 2024 14:57:43 +0100 Message-ID: <87sf1j2sh4.wl-tiwai@suse.de> From: Takashi Iwai To: Gergo Koteles Cc: linux-sound@vger.kernel.org, alsa-devel@alsa-project.org Subject: Re: PCI SSID and Codec SSID collision? In-Reply-To: References: User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Authentication-Results: smtp-out1.suse.de; none X-Spamd-Result: default: False [-0.75 / 50.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; NEURAL_HAM_LONG(-1.00)[-1.000]; RCVD_COUNT_THREE(0.00)[3]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MID_CONTAINS_FROM(1.00)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; SUBJECT_ENDS_QUESTION(1.00)[]; RCVD_TLS_ALL(0.00)[]; BAYES_HAM(-1.45)[91.29%] Message-ID-Hash: FPGG2FNMTKLAZEP4RXDA4SELLEQNU2BY X-Message-ID-Hash: FPGG2FNMTKLAZEP4RXDA4SELLEQNU2BY X-MailFrom: tiwai@suse.de X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.9 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri, 23 Feb 2024 13:05:12 +0100, Gergo Koteles wrote: > > Hi, > > The Lenovo Yoga Slim Pro 9 14IRP8 has tas2781 amplifiers, but it can > only pickup its fixup with the hda_model=17aa:38be module parameter. > > The 17aa:38be is the SSID of its Codec. The PCI SSID is 17aa:3802. > > The patch_realtek.c has these fixup: > SND_PCI_QUIRK(0x17aa, 0x3802, "Lenovo Yoga DuetITL 2021", > ALC287_FIXUP_YOGA7_14ITL_SPEAKERS), > SND_PCI_QUIRK(0x17aa, 0x38be, "Yoga S980-14.5 proX YC Dual", > ALC287_FIXUP_TAS2781_I2C), > > And the snd_hda_pick_fixup() picks the former fixup because of the same > PCI SSID, but that is a Codec SSID? > > At least it worked without that line. > https://bugzilla.kernel.org/show_bug.cgi?id=208555#c839 > > It would be nice if it can be work without the module parameter. > > What is the best way to add this strangeness to patch_realtek.c? That's a bad collision that happens rarely but more than once... In this case, we'd need to fix 17aa:3802 matching to be a special function that checks the model more closely. e.g. create a quirk function that checks the codec SSID additionally and apply the different quirks from there. thanks, Takashi