From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6AE2BEE7FF4 for ; Mon, 11 Sep 2023 06:31:21 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 78BBD846; Mon, 11 Sep 2023 08:30:28 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 78BBD846 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1694413878; bh=Eg3KgnUNpRNSqU6Gshl9UX1IZKtftgzqrmAacovn2M4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=bKa75HS/36pJzD6QQvlq918w0RVpKwOuCdD4YYM5Vyx2CvSrYfz8zkdYRF7Nq+Rui 92mI2xvXS4fMATnKh7kQM6wjLf5VoHFpaVXV2LzLbjSTvVD+27z3GFgDfxZL+G4hrr ZLGHsiJ2fWGR5TSNHJyAvjxT2kT1l/zuOF/DJBcg= Received: by alsa1.perex.cz (Postfix, from userid 50401) id D67F6F801F5; Mon, 11 Sep 2023 08:29:59 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 30EEAF801F5; Mon, 11 Sep 2023 08:29:59 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id DA23DF80425; Mon, 11 Sep 2023 08:29:54 +0200 (CEST) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 546DDF801F5 for ; Mon, 11 Sep 2023 08:29:50 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 546DDF801F5 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=BraPm3c0; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=hBjPE4wS Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 3FBEC21954; Mon, 11 Sep 2023 06:29:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1694413790; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=tr/bSdM83dCsFkG0lgZwfeOVd5FVEbn88zt0hKpSIi0=; b=BraPm3c0n2pCVnkk0GlJVS1mvUw0g+FI25kMy7FqcLLV8lN5VhCYbTkXBohgsYZ5Ps7A6j aQyxS0XgaDHWqIPRq8NGQv4cMWocGrlevZ0599sfqaeudw1NUfcjaFOR2JpyxNIX3WOBjO u1mJ2wD9AXu3AfJIEJsFm4CDIaOSHWA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1694413790; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=tr/bSdM83dCsFkG0lgZwfeOVd5FVEbn88zt0hKpSIi0=; b=hBjPE4wSYIyTP2SkjDlix+APmnvtQX2JCCd0K0yrMUPqpp9KUTUMClHdwG+yNxlAsCOFkj OyofnT+E/D0PdhAQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 161F913780; Mon, 11 Sep 2023 06:29:50 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 7tNzBN6z/mSDRgAAMHmgww (envelope-from ); Mon, 11 Sep 2023 06:29:50 +0000 Date: Mon, 11 Sep 2023 08:29:49 +0200 Message-ID: <87sf7l6x42.wl-tiwai@suse.de> From: Takashi Iwai To: Richard Fitzgerald Cc: , , , Subject: Re: [PATCH] ALSA: hda: cs35l56: Call pm_runtime_dont_use_autosuspend() In-Reply-To: <20230908101223.2656901-1-rf@opensource.cirrus.com> References: <20230908101223.2656901-1-rf@opensource.cirrus.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Message-ID-Hash: A2N4ULCD44FHXVKM3MBDJGGEAINY6MEQ X-Message-ID-Hash: A2N4ULCD44FHXVKM3MBDJGGEAINY6MEQ X-MailFrom: tiwai@suse.de X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri, 08 Sep 2023 12:12:23 +0200, Richard Fitzgerald wrote: > > Driver remove() must call pm_runtime_dont_use_autosuspend(). > > Drivers that call pm_runtime_use_autosuspend() must disable > it in driver remove(). Unfortunately until recently this was > only mentioned in 1 line in a 900+ line document so most > people hadn't noticed this. It has only recently been added > to the kerneldoc of pm_runtime_use_autosuspend(). > > Signed-off-by: Richard Fitzgerald > Fixes: 2a930a6da8ec ("ALSA: hda/cs35l56: Add driver for Cirrus Logic CS35L56 amplifier") Applied now. The Fixes tag points to a non-existing ID, so I corrected in my side to 73cfbfa9caea. thanks, Takashi > --- > sound/pci/hda/cs35l56_hda.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/sound/pci/hda/cs35l56_hda.c b/sound/pci/hda/cs35l56_hda.c > index 76b9c685560b..9e4976bdb5e0 100644 > --- a/sound/pci/hda/cs35l56_hda.c > +++ b/sound/pci/hda/cs35l56_hda.c > @@ -1003,6 +1003,7 @@ void cs35l56_hda_remove(struct device *dev) > { > struct cs35l56_hda *cs35l56 = dev_get_drvdata(dev); > > + pm_runtime_dont_use_autosuspend(cs35l56->base.dev); > pm_runtime_get_sync(cs35l56->base.dev); > pm_runtime_disable(cs35l56->base.dev); > > -- > 2.30.2 >