From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C3EC2EB64DD for ; Fri, 11 Aug 2023 07:37:26 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id A65A6210; Fri, 11 Aug 2023 09:36:33 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz A65A6210 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1691739443; bh=fNEARGdBpNV44qayK+1eoVMVWkDWYR1Ll3gFpL6RUI4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=MFPv+qNf13mSlhqvFdc6pawWWgQ1u6ReJgwg+fR/nXJP0qALj1b8u9g1AIB+Akp/k ZrTHe034KKDxKJq6IDECwY0vzeUbp/3dQZWQA/W0LJX5ZQvKDA8SjIdzDwI/GXpG2E driRoV/KyauBrv6xk+Wfe3dsGTl9da9ZSqhFirok= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 1204AF80510; Fri, 11 Aug 2023 09:36:33 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id BB9CFF8016E; Fri, 11 Aug 2023 09:36:32 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 87E7BF8016E; Fri, 11 Aug 2023 09:36:27 +0200 (CEST) Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id B2FA4F800F4 for ; Fri, 11 Aug 2023 09:36:20 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz B2FA4F800F4 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=CIlP+A5K; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=w7YR7wnW Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id F25441F74A; Fri, 11 Aug 2023 07:36:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1691739378; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=L7qTjamPWvdfEuBS2+Ub18mMrl9R2SqTrqxBlplL/4g=; b=CIlP+A5Ks2fIzAK9mQEyiOSqKjHTd4QmVV2wYYVtiBgwl4BVykRi+Q9kP82+Y2NIVsD2Fw SmmOOAlHvgIuxzXVWeG33w7B6r8fENUkZSu9qzZID7T+8Q6VdWxL7qdO7FGjmNEr7f+D96 NQmWY1Uyl9Dx4qG47i7YoquNDd5SkyM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1691739378; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=L7qTjamPWvdfEuBS2+Ub18mMrl9R2SqTrqxBlplL/4g=; b=w7YR7wnWwTqR08nvYwgv14j6zMpyCoqzDR5W02MYe2x4ilk90Qze1ECqc/rwC53JarB8r/ llJAy9sRII8tXVBw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id D4740138E2; Fri, 11 Aug 2023 07:36:18 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id ktDnMvLk1WR+aQAAMHmgww (envelope-from ); Fri, 11 Aug 2023 07:36:18 +0000 Date: Fri, 11 Aug 2023 09:36:18 +0200 Message-ID: <87sf8qrpxp.wl-tiwai@suse.de> From: Takashi Iwai To: john_candlish@mail.candlish.net Cc: alsa-devel@alsa-project.org Subject: Re: [PATCH] -- fix Boss MS-3 midi-usb communication In-Reply-To: <169173850488.20.12963803837559965998@mailman-web.alsa-project.org> References: <169173850488.20.12963803837559965998@mailman-web.alsa-project.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Message-ID-Hash: ICADABFAFCFMSVSY2BHGSIJXSARMQP4L X-Message-ID-Hash: ICADABFAFCFMSVSY2BHGSIJXSARMQP4L X-MailFrom: tiwai@suse.de X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri, 11 Aug 2023 09:21:44 +0200, john_candlish@mail.candlish.net wrote: > > This one line change gets MIDI communication flowing between ALSA and the Boss MS-3 multi-effect switcher. > > ///// > *** sound/usb/midi.c 2023-08-10 22:46:31.016346930 +0200 > --- sound/usb/midi.c-orig 2023-07-19 16:37:03.000000000 +0200 > *************** > *** 2106,2113 **** > struct usb_endpoint_descriptor *epd; > int i, out_eps = 0, in_eps = 0; > > ! if (USB_ID_VENDOR(umidi->usb_id) == 0x0582 && > ! USB_ID_PRODUCT(umidi->usb_id) != 0x01f5) > snd_usbmidi_switch_roland_altsetting(umidi); > > if (endpoint[0].out_ep || endpoint[0].in_ep) > --- 2106,2112 ---- > struct usb_endpoint_descriptor *epd; > int i, out_eps = 0, in_eps = 0; > > ! if (USB_ID_VENDOR(umidi->usb_id) == 0x0582) > snd_usbmidi_switch_roland_altsetting(umidi); > > if (endpoint[0].out_ep || endpoint[0].in_ep) > > ///// > > There are doubtless other Roland/Boss USB_ID_PRODUCT id's that are effected and it would be nice to make the USB_ID_PRODUCT value a tunable, but that is beyond my competence. Could you give the exact USB vendor/product IDs so that I can cook a patch? At best, please give alsa-info.sh output; run the script with --no-upload option and attach the output. thanks, Takashi