From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 15E7AEB64DC for ; Mon, 17 Jul 2023 07:33:40 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 16187AE9; Mon, 17 Jul 2023 09:32:48 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 16187AE9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1689579218; bh=S1XUJ4vXHy3Re5SfrgdQEiA611RB1ezLcB08n3RMj0w=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=dOk0N6nPRPiP5hZGDjV5qEkBAdVpxaG+lJJZ9XamVfx1Uj38t+7zSMKKeA6dikB7f SJQ2GJtWuHrUi0G6DOprlPMMg/RHMwck87TAZq1gFOZ/PR1AyC9WzxwCuBrp8rxtAW gqM+if1JOwgOYiN66oioxNV+x1yOCg3Dk6NXb3/A= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 27001F8027B; Mon, 17 Jul 2023 09:32:20 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 9948FF8047D; Mon, 17 Jul 2023 09:32:20 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 3B288F8047D; Mon, 17 Jul 2023 09:32:10 +0200 (CEST) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id B4612F800D2 for ; Mon, 17 Jul 2023 09:32:00 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz B4612F800D2 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=ZoFRw27I; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=U0PmJCqz Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id B942821979; Mon, 17 Jul 2023 07:31:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1689579119; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Kwf5PJ5yYfG6d3GoOoValETQZ687TvFao+QYA+jhedo=; b=ZoFRw27IvG4xobe++1BxEimsf+hWP+AEKaVAuuYX+LrwyhbZHr6bI0NwX8LYlqPizF1FG3 xYJ6Kxy7iPZPtNW0eh4GrzVRhF7XVjwVVFzzkerncBU/2f9wo/5KeH3EhaRWLA++CB52o8 4dl0kBhCPYb6GZLCmAnEZ5UWgFdZDIA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1689579119; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Kwf5PJ5yYfG6d3GoOoValETQZ687TvFao+QYA+jhedo=; b=U0PmJCqz4sb6xXdObJWJJAIQuT9WV1uMDTv2Tzv69ftsE+xhgMr2TzvtDtUt+Y51FmmSpo oxkpGY+3LXYpuOCg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 93831138F8; Mon, 17 Jul 2023 07:31:59 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 0VQeI2/utGSiCgAAMHmgww (envelope-from ); Mon, 17 Jul 2023 07:31:59 +0000 Date: Mon, 17 Jul 2023 09:31:59 +0200 Message-ID: <87sf9nj8nk.wl-tiwai@suse.de> From: Takashi Iwai To: Oswald Buddenhagen Cc: alsa-devel@alsa-project.org, Jaroslav Kysela Subject: Re: [PATCH v2] ALSA: emu10k1: track loss of external clock on E-MU cards In-Reply-To: <20230715160738.326832-1-oswald.buddenhagen@gmx.de> References: <20230715160738.326832-1-oswald.buddenhagen@gmx.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Message-ID-Hash: OKOOUQR5Y3LXY7AWZD7MMOUAE62ULYYC X-Message-ID-Hash: OKOOUQR5Y3LXY7AWZD7MMOUAE62ULYYC X-MailFrom: tiwai@suse.de X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Sat, 15 Jul 2023 18:07:38 +0200, Oswald Buddenhagen wrote: > > This uses IRQs to track spontaneous changes to the word clock source > register. > > FWIW, that this can happen in the first place is the reason why it is > futile to lock the clock source mixer setting while the device is open - > we can't consistently control the rate anyway. Though arguably, we > should reset any open streams when that happens, as they become > corrupted anyway. > > Signed-off-by: Oswald Buddenhagen > > --- > v2: > - use driver-local lock instead of core's control_rwsem > > --- > FIXME? while i'm not sure, i think this won't notice seamless switches > between 44.1 and 48 kHz. assuming that's the case, this seems like a > minor issue: firstly, just about nothing actually produces such a > seamless switch - my only device that can even do that is the e-mu card > itself, but the driver disrupts that by temporarily muting the output. > secondly, the user is unlikely to select an external source before > setting it up properly. and the easy workaround is actually never doing > that. > regardless, to actually test that i'd need a second e-mu card. The code change itself looks sane, so I took the patch as is now. thanks, Takashi