From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 795D6C7618E for ; Sat, 22 Apr 2023 08:48:09 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 4968BE82; Sat, 22 Apr 2023 10:47:17 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 4968BE82 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1682153287; bh=S044oUcXbvFxxcrkAa35klpPPWz0mTvsQbXssiE0Xqs=; h=Date:From:To:Subject:In-Reply-To:References:CC:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=swYn3J6d4Bmf6nnMYZNHctHjPoqJ+trZg7tnew/P2ij7LENmczFZ03u5HxNkK94pD NrDINNL7lTsfEqxzF4NktLZEUZ+KHg9+Wqe7ozjnm0KWICtYM+K99KbGj35Ls0hEjK njuyFozkG5lYsCTMN/YJp2YPQkmANxnWmkJFKpLs= Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 51319F80155; Sat, 22 Apr 2023 10:46:52 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id A6416F80155; Sat, 22 Apr 2023 10:46:48 +0200 (CEST) Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 46959F80053 for ; Sat, 22 Apr 2023 10:46:45 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 46959F80053 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=RL3ygLqM; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=agg2Z4w3 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 48D9A1FDEE; Sat, 22 Apr 2023 08:46:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1682153205; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Nm21AJwsKHZokb3kAFgGk3vec+/smm9/sFXZeZHuX5A=; b=RL3ygLqMZ9wVONEpaTrS//heRsEkj1F9R9g8bXFPY8iTddCjbq4jiM8BOLfuJ6MMjhUtRx 2V4bnh58noaV7numvvGaLzB1cGZmtaQEI3+/Usi0S01F0ObvRAQ4apOqeIVB+bCLX0iE6h by60B7IZ9NgWVFo0UjoEHwMsdPxiHdg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1682153205; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Nm21AJwsKHZokb3kAFgGk3vec+/smm9/sFXZeZHuX5A=; b=agg2Z4w3M0/8T6GLKBDMF611IRpTki5qxxbh5uuu68MdnyXG67kYvZNjV2BAEWHVzzGn+Z jz7Q0w20WFy/1FDQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 3092713499; Sat, 22 Apr 2023 08:46:45 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id HjkMC/WeQ2SWOgAAMHmgww (envelope-from ); Sat, 22 Apr 2023 08:46:45 +0000 Date: Sat, 22 Apr 2023 10:46:44 +0200 Message-ID: <87sfcspamj.wl-tiwai@suse.de> From: Takashi Iwai To: Oswald Buddenhagen Subject: Re: [PATCH 1/7] ALSA: emu10k1: properly assert E-MU FPGA access constaints In-Reply-To: <20230421141006.1005539-1-oswald.buddenhagen@gmx.de> References: <20230421141006.1005539-1-oswald.buddenhagen@gmx.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Message-ID-Hash: LKLVCY2AYRKGC4RXMHALTRCE76U7E7RX X-Message-ID-Hash: LKLVCY2AYRKGC4RXMHALTRCE76U7E7RX X-MailFrom: tiwai@suse.de X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: alsa-devel@alsa-project.org X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri, 21 Apr 2023 16:10:00 +0200, Oswald Buddenhagen wrote: > > Assert the validity of the registers and values, as them being out of > range would indicate an error in the driver. Consequently, don't bother > returning error codes; they were ignored everywhere anyway. > > Signed-off-by: Oswald Buddenhagen I applied a part of the series (patches 1, 2, 4, 5, 6, 7) now. Please resubmit the patch 3. thanks, Takashi