From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8B1A7C38142 for ; Tue, 31 Jan 2023 08:34:03 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 0C502DF6; Tue, 31 Jan 2023 09:33:11 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 0C502DF6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1675154041; bh=COwHdh7Cw7mYuUPox64TbMSGJ8+ae+BRD98txjBg494=; h=Date:From:To:Subject:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=Qlkzj9IYY4ir3birX4NYm1aUlHKcX8lDEK/BcWFdowVTktNpMXqYipe/THaJs3WbN VeR16X0EwUavgCpZizHHt/d7RPYyFfpeyDcfG4Vlm1iAg0Yfa9dCiTJ6ewNGZaq3P/ C3weE91shAJgnvkK2gfkDYs6y4XRCKP+gKQB9x4Q= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 98F35F80245; Tue, 31 Jan 2023 09:33:10 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 91128F804C2; Tue, 31 Jan 2023 09:33:09 +0100 (CET) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 91726F80169 for ; Tue, 31 Jan 2023 09:33:04 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 91726F80169 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=oYm7HzW5; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=Xy4IT27r Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 71F7822432; Tue, 31 Jan 2023 08:33:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1675153984; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=85fTq5NYof6ox1/plwgNt287rPeZxlqnGz3fiJo7uyM=; b=oYm7HzW55icfr6+1rDO21jZlJ+uV7fV0aCk7VQ76O2OWlxjaXKVGgSiren9UnrlTZ6HLQD jjGDCWkzAygeOh8n9A9Fs9WStzrp5lo48YNfuW7Xogdk9J7qfuc5hhwLcMcQWckfVNwCkq TXzOPCU9tXgLbX4cDxJ2lh0Rt/TfRkA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1675153984; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=85fTq5NYof6ox1/plwgNt287rPeZxlqnGz3fiJo7uyM=; b=Xy4IT27rE0Axl1qsK/Y83NhW+3NhCHsJBkGD5k+trCwv28WXmIkpb55fUuCrYer/IRBpsI s2P8I5kNlHvcitBQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 551F713585; Tue, 31 Jan 2023 08:33:04 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id H8TpE0DS2GOqGQAAMHmgww (envelope-from ); Tue, 31 Jan 2023 08:33:04 +0000 Date: Tue, 31 Jan 2023 09:33:03 +0100 Message-ID: <87sffrp0hs.wl-tiwai@suse.de> From: Takashi Iwai To: Takashi Sakamoto Subject: Re: [PATCH] ALSA: firewire-lib: fix uninitialized local variable In-Reply-To: <20230130141532.102838-1-o-takashi@sakamocchi.jp> References: <20230130141532.102838-1-o-takashi@sakamocchi.jp> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alsa-devel@alsa-project.org, Dan Carpenter Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Mon, 30 Jan 2023 15:15:32 +0100, Takashi Sakamoto wrote: > > The function local variable, curr_cycle_time is declared without > initialization. When tracepoints event is not probed, it looks to be > used as is. This commit fixes it. Fortunately, the value of local variable > is not used unless the event is probed, thus this commit is for better > coding. > > Reported-by: Dan Carpenter > Fixes: fef4e61b0b7 ("ALSA: firewire-lib: extend tracepoints event including CYCLE_TIME of 1394 OHCI") > Signed-off-by: Takashi Sakamoto Thanks, applied now (with the correction of Fixes tag). Takashi