From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8F187C433FE for ; Tue, 1 Nov 2022 10:52:17 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id BC9AC168D; Tue, 1 Nov 2022 11:51:24 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz BC9AC168D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1667299934; bh=Rm3T8xtZLx+mP3fX+g+Dz+UaJAxO3wJiS1ItSslh8hk=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=cCpLygVVZJnBQIx4KcHt0E04+ZudarN8KGdAk+xYSzb/38q1X8t5BMe6ii+lZ/MLH WxlWEo494teqCP9Yjviye5GeWKITiadVFW3R9AgaY+ya1E3uKnJnE3peydcDcZD4BO pBMEIEyuGAg1FoNsvzbMXJRVcOywtGg3pOPPW3R4= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 4E9F9F8028D; Tue, 1 Nov 2022 11:51:24 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 0FD69F80155; Tue, 1 Nov 2022 11:51:22 +0100 (CET) Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id E63BFF80155 for ; Tue, 1 Nov 2022 11:51:15 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz E63BFF80155 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="nldf51+c"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="XZsZkWBt" Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 9AAAA1F90C; Tue, 1 Nov 2022 10:51:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1667299874; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=m/tqrif9gECCnlmuhAd8sLJgbFa5N5fA0sPSNU+Auuo=; b=nldf51+cWxZToDl2oJppnS38MKItOf9HUZ0e3Qp59Ofvl9/6R27wdh8GuqXrM7FlAslaai aVNBMIc6ChDpEx0kwf6JgpRndGHsX7eOShiVQh29gp4twkdudqq2Mhm7htA/FAs+jRSUYO Wi61AKep7PTizuyti+Ay4d15ojqRkVY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1667299874; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=m/tqrif9gECCnlmuhAd8sLJgbFa5N5fA0sPSNU+Auuo=; b=XZsZkWBtMJBQ+Argnqeck0V6ZBHzz5N8k3L5EFfkP2bvyMwBZXB4BjTx0fUKQOBDQUEWTI JC6/s0JlOtg32EDw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 720571346F; Tue, 1 Nov 2022 10:51:14 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id NV2yGSL6YGPIXwAAMHmgww (envelope-from ); Tue, 01 Nov 2022 10:51:14 +0000 Date: Tue, 01 Nov 2022 11:51:13 +0100 Message-ID: <87sfj36j8e.wl-tiwai@suse.de> From: Takashi Iwai To: Pierre-Louis Bossart Subject: Re: [PATCH] ALSA: hda: clarify comments on SCF changes In-Reply-To: <20221031195505.249929-1-pierre-louis.bossart@linux.intel.com> References: <20221031195505.249929-1-pierre-louis.bossart@linux.intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Cc: alsa-devel@alsa-project.org, broonie@kernel.org, Ranjani Sridharan , Rander Wang X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Mon, 31 Oct 2022 20:55:05 +0100, Pierre-Louis Bossart wrote: > > The commit 1f9d3d98694b1 ("ALSA: hda - set intel audio clock to a > proper value") added a number of misleading comments. > > There is no ability to detect if an SCF value was set or not, what the > code does is prevent the use of the 6MHz audio clock represented by > the value 0 in LCTL.SCF. Changing the SCF settings does require the > link to be power-cycled, but in all other cases the link is powered > automatically when exiting reset. In other words, the power-cycle is > an exception to the rule that the HDaudio legacy driver does not need > to program SPA/CPA bits. > > In addition, the SCF related changes are only relevant for the first > link. > > No functionality change, only comment clarifications. > > Signed-off-by: Pierre-Louis Bossart > Reviewed-by: Ranjani Sridharan > Reviewed-by: Rander Wang Thanks, applied. Takashi