From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 61B0AC43334 for ; Fri, 17 Jun 2022 08:47:51 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id A342C1B3F; Fri, 17 Jun 2022 10:46:59 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz A342C1B3F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1655455669; bh=DzllmykMdRtqbW4kwLgu2CCt/UnHsUq4T/Lk/K/p8uw=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=nNzoPkWiqlSDIu7xgmdU9KORwwhO5sKwFT/ec8dp6N60lP+4Xjy5qne7c8mC4Ldsr iLWyq96HWxS0gQWT5msDu1ZKIkkK8xayEYn211yTCvSQX6VvSj2nxc6tlUw0Z7lw2a ESVMYLEPBvvUMXvQXVYE9tH18RvtZJnh5eksdjZg= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 332F0F80311; Fri, 17 Jun 2022 10:46:59 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 3713CF80311; Fri, 17 Jun 2022 10:46:58 +0200 (CEST) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id E006EF800D3 for ; Fri, 17 Jun 2022 10:46:54 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz E006EF800D3 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="0AqWbyYJ"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="XO8WWeac" Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id D996121E82; Fri, 17 Jun 2022 08:46:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1655455613; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=UVmlNAgDK7iLU5aby+2aK0Rxh7H/LeeuqFQf5sKOCzI=; b=0AqWbyYJfiNfNiObKBKsPjvWen5MD0l0U+qh9pC3IngIq5//DI4aaZtOAO45Cp9FI8zUgF adt+Zp1fisrC21dv5Yl2n4OBisg8x7knHW6gprTNSOavNu05U9wegXo9g3qc9RtZdf7/oh 10g50zFp+sViv4rHDeBJyn4uiDsda/k= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1655455613; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=UVmlNAgDK7iLU5aby+2aK0Rxh7H/LeeuqFQf5sKOCzI=; b=XO8WWeacWnKEVsCAPB5PssqoWy2oixjqI5w4FPnB18+q9J6m2/fC4ryIYsJyUmniyCJN4k Y9X8rhHVyH/toJDQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id B9FA213458; Fri, 17 Jun 2022 08:46:53 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id AlulLH0/rGIWHgAAMHmgww (envelope-from ); Fri, 17 Jun 2022 08:46:53 +0000 Date: Fri, 17 Jun 2022 10:46:53 +0200 Message-ID: <87sfo31xtu.wl-tiwai@suse.de> From: Takashi Iwai To: Pierre-Louis Bossart Subject: Re: [PATCH 0/2] ALSA: x86: intel_hdmi_audio: pm_runtime updates In-Reply-To: <20220616222910.136854-1-pierre-louis.bossart@linux.intel.com> References: <20220616222910.136854-1-pierre-louis.bossart@linux.intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Cc: Hans de Goede , alsa-devel@alsa-project.org, broonie@kernel.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Fri, 17 Jun 2022 00:29:08 +0200, Pierre-Louis Bossart wrote: > > While cleaning up the code to use pm_runtime_resume_and_get(), I > realized we never called pm_runtime_enable() for this driver. This is > potentially very invasive and error-prone, so feedback and test > results are welcome - all my BYT/CHT devices are not longer functional > unfortunately, and our CI MinnowBoard uses the 'other' HDMI solution > based on HDaudio. > > In addition, the resume was assumed to be always successful, which > isn't a very good idea. > > Pierre-Louis Bossart (2): > ALSA: x86: intel_hdmi_audio: enable pm_runtime and set autosuspend > delay > ALSA: x86: intel_hdmi_audio: use pm_runtime_resume_and_get() Applied both patches now. Thanks. Takashi