From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DF696EB64D7 for ; Mon, 26 Jun 2023 11:14:46 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 7EC78839; Mon, 26 Jun 2023 13:13:54 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 7EC78839 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1687778084; bh=62c3Y86+OLkF4s7dXix5zSxvKy2EOIzqBdqAnDGHfCM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=kducOWXkR3hSk411SDSxsH3uIVfRa4H45QQ9QXR7Cv2T2+o+eX4JSjOxvHEyZoS8C nSqCGMkCnL2LNNKSBBKfMkbqY7Cjrd2Xxj15WREFj5uESCVbC7jQDyFkT7MArMGE1w bUB1FRdexZ7H2BVsD3K1f1Yy6sU2Zy/UsSeIRSb0= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 2437CF800E3; Mon, 26 Jun 2023 13:13:29 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id B3161F80431; Mon, 26 Jun 2023 13:13:29 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 690D8F80246; Mon, 26 Jun 2023 13:13:26 +0200 (CEST) Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 36057F800E3 for ; Mon, 26 Jun 2023 13:13:23 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 36057F800E3 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=xDSvj+cA; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=MTQZUZ7D Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id ACC391F8AB; Mon, 26 Jun 2023 11:13:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1687778003; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=vKaUDMX7q/k4wnF5zn+Vr6K9ID3Iq87i7XrGFy/yZkk=; b=xDSvj+cA2CrQW1d62/Hj9ME9axiJ+O/23UMa+mgChTWNbHzBw4uM/vWi5T1dR2joITeEOE H3MVyOpfp1IeqA5cjVs3PZ79QjwUlCIzZ5M5oLdtunX6FHbqJHZUXQPVLgQQmNO0rZYtna VyTxkWulNw7C7ahnlnVhHJzmMyPOHiQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1687778003; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=vKaUDMX7q/k4wnF5zn+Vr6K9ID3Iq87i7XrGFy/yZkk=; b=MTQZUZ7DNlmCoXdgQk6JahE7IEQ55oYgyNPsqB40wbT1iqRA8yXqESqu/5jzwapNseMsTk UC6JtrgSrpqJw0Cw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 7F3FF13483; Mon, 26 Jun 2023 11:13:23 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id RToNHtNymWT4JAAAMHmgww (envelope-from ); Mon, 26 Jun 2023 11:13:23 +0000 Date: Mon, 26 Jun 2023 13:13:21 +0200 Message-ID: <87ttuuv5m6.wl-tiwai@suse.de> From: Takashi Iwai To: Jaroslav Kysela Cc: Tuo Li , tiwai@suse.com, alsa-devel@alsa-project.org, Linux Kernel , baijiaju1990@outlook.com Subject: Re: [BUG] ALSA: core: pcm_memory: a possible data race in do_alloc_pages() In-Reply-To: <45445f57-0a73-59e6-6f3d-3983ce93a324@perex.cz> References: <877crqwvi1.wl-tiwai@suse.de> <871qhywucj.wl-tiwai@suse.de> <4d0931bf-b356-6969-5aaf-b663d7f2b21a@perex.cz> <87wmzqv64o.wl-tiwai@suse.de> <45445f57-0a73-59e6-6f3d-3983ce93a324@perex.cz> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Message-ID-Hash: XNKSX5J7N4TNOV6MO4SLVVISK75AER47 X-Message-ID-Hash: XNKSX5J7N4TNOV6MO4SLVVISK75AER47 X-MailFrom: tiwai@suse.de X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Mon, 26 Jun 2023 13:09:00 +0200, Jaroslav Kysela wrote: > > On 26. 06. 23 13:02, Takashi Iwai wrote: > > On Mon, 26 Jun 2023 09:56:47 +0200, > > Jaroslav Kysela wrote: > >> > >> On 26. 06. 23 9:33, Takashi Iwai wrote: > >>> On Mon, 26 Jun 2023 09:31:18 +0200, > >>> Tuo Li wrote: > >>>> > >>>> > >>>> Hello, > >>>> > >>>> Thank you for your reply! > >>> > >>> FWIW, the simplest fix would be something like below, just extending > >>> the mutex coverage. But it'll serialize the all calls, so it might > >>> influence on the performance, while it's the safest way. > >> > >> It may be better to update total_pcm_alloc_bytes before > >> snd_dma_alloc_dir_pages() call and decrease this value when allocation > >> fails to allow parallel allocations. Then the mutex can be held only > >> for the total_pcm_alloc_bytes variable update. > > > > Yes, it'd work. But a tricky part is that the actual allocation size > > can be bigger, and we need to correct the total_pcm_alloc_bytes after > > the allocation result. So the end result would be a patch like below, > > which is a bit more complex than the previous simpler approach. But > > it might be OK. > > The patch looks good, but it may be better to move the "post" variable > updates to an inline function (mutex lock - update - mutex unlock) for > a better readability. Sounds like a good idea. Let me cook later. Takashi