From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7C76CC7618E for ; Sat, 22 Apr 2023 08:46:27 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 6362FEA8; Sat, 22 Apr 2023 10:45:34 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 6362FEA8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1682153184; bh=p1rdsI/8MSu15PVWgDHMVyWB9UQPpR6URWO1aPtKYWo=; h=Date:From:To:Subject:In-Reply-To:References:CC:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=inIhUzDcRYw6QPRtPQQkv4DhZBJkyUwFegpOOdlEEyqubqu/sRNDYF+OwNvFsgeN+ B6/RcuX+jY4S3XIpmCbDKhDgogolb62KbOzwinbLtKtW5hOCz/Ys63zxBSUjEaKOy9 t++9QRFrhwOkoejHOUQIgS/JT5HB/OU2cv7nbHyU= Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id BFF50F80155; Sat, 22 Apr 2023 10:45:08 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 74819F80155; Sat, 22 Apr 2023 10:45:03 +0200 (CEST) Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 95149F80053 for ; Sat, 22 Apr 2023 10:44:55 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 95149F80053 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=Ko5AunzW; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=F9cmrAai Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 7332F1FDEE; Sat, 22 Apr 2023 08:44:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1682153095; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=0N9PPbf1Y7q6jv+DTq9nrWw3hQQAgvlDRUeOJapgjyc=; b=Ko5AunzW30CwbxbB9ONy8cuG/5xPjvUDm89ffDp4Ko0x6oWmgLQkL2cqsYoOCFpe06fmZ6 hJaXwaKjr+GLHQvP8fXu1WThDn+rfuHltLG8vFdBzl2tsWGIok+QuNt99EsmRZgxgw0xPB GFNE1JWBAMnp3Be7zmJkLPqNRxh3yCE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1682153095; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=0N9PPbf1Y7q6jv+DTq9nrWw3hQQAgvlDRUeOJapgjyc=; b=F9cmrAaiLE1Z6WaEbe51dj9yfex73Ti9Ckq8+I0o0rXSv6qnD/+GeCMT2XFQvYg0B8H/Lx 3qU39ynzJ2FulHDA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 38B4513499; Sat, 22 Apr 2023 08:44:55 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id cX3lDIeeQ2TiOQAAMHmgww (envelope-from ); Sat, 22 Apr 2023 08:44:55 +0000 Date: Sat, 22 Apr 2023 10:44:54 +0200 Message-ID: <87ttx8papl.wl-tiwai@suse.de> From: Takashi Iwai To: Oswald Buddenhagen Subject: Re: [PATCH 1/7] ALSA: emu10k1: drop redundant snd_emu10k1_efx_playback_hw_free() In-Reply-To: <87r0sdqo5n.wl-tiwai@suse.de> References: <20230421141006.1005452-1-oswald.buddenhagen@gmx.de> <87r0sdqo5n.wl-tiwai@suse.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Message-ID-Hash: 2MU7MME5DR6GT6G3IMIJBEDEEFALUQSL X-Message-ID-Hash: 2MU7MME5DR6GT6G3IMIJBEDEEFALUQSL X-MailFrom: tiwai@suse.de X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: alsa-devel@alsa-project.org X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri, 21 Apr 2023 16:56:52 +0200, Takashi Iwai wrote: > > On Fri, 21 Apr 2023 16:10:00 +0200, > Oswald Buddenhagen wrote: > > > > Or actually, replace snd_emu10k1_playback_hw_free() with it, as that is > > a subset. > > > > Signed-off-by: Oswald Buddenhagen > > The code changes in the whole patch series look OK, but still a few > minor corrections in the change logs (missing commit summary, etc) are > needed. > > Also, when you submit this size of patch series, please make a cover > letter and explain what the series are intended. I applied applicable ones in the series (patches 1, 2, 3, 5, 7) now. Please resubmit patches 4 and 6. thanks, Takashi