From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E4C76C77B75 for ; Fri, 5 May 2023 10:46:17 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id EF9D02C61; Fri, 5 May 2023 12:45:24 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz EF9D02C61 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1683283575; bh=hXnxx/cLPhjR+upjuT9hx+fuYJpNLskhTnN4dwo/CZk=; h=Date:From:To:Subject:In-Reply-To:References:CC:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=IO6u66VVwW4Os40nJBIb48M3h3mCAYlZmBVwUYam4rqwmMUdmFdFJ1pnN6isDkR6+ VRok2ntfdeMfTd6NtXclfVXgimSRTyhttwYz5Ovpec40xdeHGEarL9jLngmYKbSZoG ODKibl3VQ2kC+TRDHjCCxA8vRIjxa53tX4z2CMAs= Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 0C785F80087; Fri, 5 May 2023 12:45:00 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 91D05F8052D; Fri, 5 May 2023 12:44:56 +0200 (CEST) Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 765BEF80087 for ; Fri, 5 May 2023 12:44:52 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 765BEF80087 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=k4hDdDs5; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=eIGnJE4g Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 94B38222FD; Fri, 5 May 2023 10:44:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1683283491; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Du9pJAbjweqduGEek3CyHDGDgJqpOWilNpuYN/EZhZM=; b=k4hDdDs5CKJ2L09Or53xRr1FYBY4dfLZPL5++H8w0qSc5mhyQWmzGN8EqEXI9jYvj6JWYW iagyQmNQGRXhQ9SvpakEmMdQUpA0+k70PtjYsKJv0815qf4YuJ/UCqf0BPsCsfWTOmXjYw utpNd14+nL2vqTWFftX8wB7gAWbJMCk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1683283491; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Du9pJAbjweqduGEek3CyHDGDgJqpOWilNpuYN/EZhZM=; b=eIGnJE4g9zAx7JFQg7RduvXW11RDKatpOeueBtTXzji+ctxJoGDini/kaEiIZTkJmAGouR DlEskNZz6T2qGABQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 63A2D13513; Fri, 5 May 2023 10:44:51 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id LuSOFyPeVGR1AgAAMHmgww (envelope-from ); Fri, 05 May 2023 10:44:51 +0000 Date: Fri, 05 May 2023 12:44:50 +0200 Message-ID: <87v8h7hxb1.wl-tiwai@suse.de> From: Takashi Iwai To: Oswald Buddenhagen Subject: Re: [PATCH 1/5] ALSA: pcm: Revert "ALSA: pcm: rewrite snd_pcm_playback_silence()" In-Reply-To: References: <20230505073813.1219175-1-perex@perex.cz> <20230505073813.1219175-2-perex@perex.cz> <87zg6ji0pn.wl-tiwai@suse.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Message-ID-Hash: 4VCJWNEOZLI2VIJ4QO3BZGBBBWTJ6UU2 X-Message-ID-Hash: 4VCJWNEOZLI2VIJ4QO3BZGBBBWTJ6UU2 X-MailFrom: tiwai@suse.de X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: ALSA development X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri, 05 May 2023 11:38:45 +0200, Oswald Buddenhagen wrote: > > On Fri, May 05, 2023 at 11:31:16AM +0200, Takashi Iwai wrote: > > On Fri, 05 May 2023 09:38:09 +0200, > > Jaroslav Kysela wrote: > >> Signed-off-by: Jaroslav Kysela > > > > Better to add Reported-by and the reference for the original thread > > reporting the regression, > > > i'll post a slight rework of the series shortly, where i'll include > this. > > > as well as the Fixes tag. > > > that seems pointless for a revert, as all the info is already included > anyway, no? People tend to look at Fixes tag to judge whether the commit can fix something real or not. For example, we (at SUSE) regularly check Fixes tag to pick up the missing fixing. In the case of a revert, it doesn't mean always a fix. So it's not mandatory, but would be still helpful. thanks, Takashi