From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4AE75C636CD for ; Fri, 10 Feb 2023 09:12:11 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id E4806846; Fri, 10 Feb 2023 10:11:18 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz E4806846 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1676020329; bh=mdlPzHnlq16VcDPPK/DmbMNssybY7JdKRYpdnncSrmA=; h=Date:From:To:Subject:In-Reply-To:References:CC:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=ohY9euzt3Ru8SWMcQa6+c6s54r51BM8s6JDkuN7BByuSE5HZGzZ0o/lZ3/xknelhg 3Hlj3JadnedY5gjrHe/7oOnP1nYAFUWxCoq+Lk5KqUgLVXGf/z9kcpEo1c350DwXD9 ckyMBqyWGI3z3xuky8991jdyqtIgtbVosgelsEyk= Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 34A63F800E4; Fri, 10 Feb 2023 10:10:53 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 57228F800E4; Fri, 10 Feb 2023 10:10:49 +0100 (CET) Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id EC74EF80094 for ; Fri, 10 Feb 2023 10:10:41 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz EC74EF80094 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=Zk2QgIaC; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=TVcoP6/Y Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 20BFB3FBE7; Fri, 10 Feb 2023 09:10:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1676020241; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=IF9tt9i6pRkjAdiKbukDmKj4BSuH9YjD5pGYMZ5t3hE=; b=Zk2QgIaClHkiHVYi+SlaqluM1tUB+mmyTO3ySICBd41ad7PTin7ofyXiu1W13rzUBpAqQ6 teQIWb8NsfuATS0iI7uDQHB1vmHiK0f2q5bJRAuPIxEt5I3gErHE6VWTGZkHLQEC+GRA5G zAMpWZXWjAe75nEWRAw7pPQgbId7im4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1676020241; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=IF9tt9i6pRkjAdiKbukDmKj4BSuH9YjD5pGYMZ5t3hE=; b=TVcoP6/Y/30UqsEpANRRPaBxbBAC8eDQ9nEl3StAzkQqlsZSoCbg4wkDu/KMBa/LVWuAIL eFXRyoUuELk2p+CQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id F103813588; Fri, 10 Feb 2023 09:10:40 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id up08OhAK5mM3IQAAMHmgww (envelope-from ); Fri, 10 Feb 2023 09:10:40 +0000 Date: Fri, 10 Feb 2023 10:10:40 +0100 Message-ID: <87v8k9j373.wl-tiwai@suse.de> From: Takashi Iwai To: Stefan Binding Subject: Re: [PATCH v1 1/3] ALSA: hda/cs35l41: Fix error condition check In-Reply-To: <20230209160403.838326-2-sbinding@opensource.cirrus.com> References: <20230209160403.838326-1-sbinding@opensource.cirrus.com> <20230209160403.838326-2-sbinding@opensource.cirrus.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Message-ID-Hash: 4WES5PWNUFMURCESFIR4QI4IRVJRKKVS X-Message-ID-Hash: 4WES5PWNUFMURCESFIR4QI4IRVJRKKVS X-MailFrom: tiwai@suse.de X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Takashi Iwai , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, patches@opensource.cirrus.com, Vitaly Rodionov X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu, 09 Feb 2023 17:04:01 +0100, Stefan Binding wrote: > > From: Vitaly Rodionov > > Function hda_cs_dsp_write_ctl() returns 3 possible values: > 0 - no change, 1 - value has changed and -1 - error, so value 1 > is not an error. > > Signed-off-by: Vitaly Rodionov When you submit a patch, you must add your Signed-off-by line. Also, this looks like no new bug, so it's worth to add Fixes tag, if any? (Not only about this patch but others, too.) Last but not least, please make the subject prefix consistent over the patch series. thanks, Takashi