Re: [PATCH] ALSA: hda/conexant: Add quirk for Acer Aspire Go 16 mic mute LED

[Takashi Iwai <tiwai@suse.de>]

On Sun, 11 Oct 2026 13:37:09 +0200,
Gonçalo Miranda wrote:
> 
> The Acer Aspire Go 16 (AG16-71P) uses a Conexant SN6180 codec
> (subsystem ID 0x1025:0x1937) with the microphone mute LED wired
> to GPIO4. Add a quirk entry so the kernel drives the LED in sync
> with the microphone mute state.
> 
> The fixup reuses the existing cxt_setup_mute_led() helper with
> mask 0x10, matching the behavior verified on the hardware.
> 
> Signed-off-by: Gonçalo Miranda <me@goncalom.dev>
> ---
>  sound/hda/codecs/conexant.c | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 
> diff --git a/sound/hda/codecs/conexant.c b/sound/hda/codecs/conexant.c
> index 40da2832b..f66bae098 100644
> --- a/sound/hda/codecs/conexant.c
> +++ b/sound/hda/codecs/conexant.c
> @@ -283,6 +283,7 @@ enum {
>  	CXT_FIXUP_HP_SPECTRE,
>  	CXT_FIXUP_HP_GATE_MIC,
>  	CXT_FIXUP_MUTE_LED_GPIO,
> +	CXT_FIXUP_ACER_ASPIRE_GO_MUTE_LED,
>  	CXT_FIXUP_HP_ELITEONE_OUT_DIS,
>  	CXT_FIXUP_HP_ZBOOK_MUTE_LED,
>  	CXT_FIXUP_HEADSET_MIC,
> @@ -786,6 +787,13 @@ static void cxt_fixup_hp_zbook_mute_led(struct hda_codec *codec,
>  		cxt_setup_mute_led(codec, 0x10, 0x20);
>  }
>  
> +static void cxt_fixup_acer_aspire_go_mute_led(struct hda_codec *codec,
> +					      const struct hda_fixup *fix, int action)
> +{
> +	if (action == HDA_FIXUP_ACT_PRE_PROBE)
> +		cxt_setup_mute_led(codec, 0, 0x10);
> +}
> +
>  static void cxt_fixup_hp_a_u(struct hda_codec *codec,
>  			     const struct hda_fixup *fix, int action)
>  {
> @@ -985,6 +993,10 @@ static const struct hda_fixup cxt_fixups[] = {
>  		.type = HDA_FIXUP_FUNC,
>  		.v.func = cxt_fixup_mute_led_gpio,
>  	},
> +	[CXT_FIXUP_ACER_ASPIRE_GO_MUTE_LED] = {
> +		.type = HDA_FIXUP_FUNC,
> +		.v.func = cxt_fixup_acer_aspire_go_mute_led,
> +	},
>  	[CXT_FIXUP_HP_ELITEONE_OUT_DIS] = {
>  		.type = HDA_FIXUP_FUNC,
>  		.v.func = cxt_fixup_update_pinctl,
> @@ -1098,6 +1110,7 @@ static const struct hda_quirk cxt5066_fixups[] = {
>  	SND_PCI_QUIRK(0x103c, 0x82b4, "HP ProDesk 600 G3", CXT_FIXUP_HP_MIC_NO_PRESENCE),
>  	SND_PCI_QUIRK(0x103c, 0x836e, "HP ProBook 455 G5", CXT_FIXUP_MUTE_LED_GPIO),
>  	SND_PCI_QUIRK(0x103c, 0x837f, "HP ProBook 470 G5", CXT_FIXUP_MUTE_LED_GPIO),
> +	SND_PCI_QUIRK(0x1025, 0x1937, "Acer Aspire Go 16", CXT_FIXUP_ACER_ASPIRE_GO_MUTE_LED),
>  	SND_PCI_QUIRK(0x103c, 0x83b2, "HP EliteBook 840 G5", CXT_FIXUP_HP_DOCK),
>  	SND_PCI_QUIRK(0x103c, 0x83b3, "HP EliteBook 830 G5", CXT_FIXUP_HP_DOCK),
>  	SND_PCI_QUIRK(0x103c, 0x83d3, "HP ProBook 640 G4", CXT_FIXUP_HP_DOCK),

The fixup table is sorted in PCI SSID order.  Please put the new entry
at the right position.

Also, the correct place for the sound kernel patch submission is
linux-sound ML (linux-sound@vger.kernel.org) instead of alsa-devel ML.
The latter is only for user-space stuff now.  Please resubmit to the
former ML, instead.


thanks,

Takashi