From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CD55BC0015E for ; Tue, 15 Aug 2023 14:57:00 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id DFDFA828; Tue, 15 Aug 2023 16:56:07 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz DFDFA828 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1692111418; bh=9B0DbEpKj/7dMR+D5JHM407xJkkN1X8qOC5mVpxZeCw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=ihWWnWLgvwDCJ3p4st3u4Ww1OXqlTHa3ht0bGkLRCL5xl+wMsFWcNM38ji9Km/L+X aubftHa6biC/szH8qSdzJBsyGC83T+omJ+d3272OmNkzcGeBIG5ecggnpLIkBd6O2c eHGM7v2rsj5z+tD+mGFFLzM5tdE6Ttk/50uCRah8= Received: by alsa1.perex.cz (Postfix, from userid 50401) id F19AFF8016D; Tue, 15 Aug 2023 16:55:32 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 6C398F8016D; Tue, 15 Aug 2023 16:55:32 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 49291F8016D; Tue, 15 Aug 2023 16:55:29 +0200 (CEST) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id F0867F800EE for ; Tue, 15 Aug 2023 16:55:25 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz F0867F800EE Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=hS9voDS/; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=jQk0O+C1 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 7EB7D21998; Tue, 15 Aug 2023 14:55:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1692111325; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=JLDnJdtBboOzyyIx903oCw+Ll6926wvxH5IbOUNGaQ0=; b=hS9voDS/OSWD6QL8twRLl9yKCOqm5wgvH6z9kjjEzFh8Sey2ADyI6UsuZXrXx/cc1y0+SW xuPei76pkDyd3KyNaIVKG+lDB/DrFS+WzZB2XvSHfNl6Ism2B2s4A3Xc+TcU+NP9aqaI8L bukQe/jaSJ9MqhuHAZjPQjZKSzmwSQk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1692111325; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=JLDnJdtBboOzyyIx903oCw+Ll6926wvxH5IbOUNGaQ0=; b=jQk0O+C1+0bfvjNW5sl3Ztgl9WeuelKU0EwYysvH1/Yl8VoxUSwio+nNKflPp5QmI/Dcd3 NG+dmVm0jWb13sBQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 55FFB13909; Tue, 15 Aug 2023 14:55:25 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 6O/9E92R22Q9YgAAMHmgww (envelope-from ); Tue, 15 Aug 2023 14:55:25 +0000 Date: Tue, 15 Aug 2023 16:55:24 +0200 Message-ID: <87wmxwxsmb.wl-tiwai@suse.de> From: Takashi Iwai To: Andy Shevchenko Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Lars-Peter Clausen , Mark Brown Subject: Re: [PATCH 21/25] ASoC: dmaengine: Convert to generic PCM copy ops In-Reply-To: References: <20230814115523.15279-1-tiwai@suse.de> <20230814115523.15279-22-tiwai@suse.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Message-ID-Hash: LVGPVEAOAVAW3YZGX4CU2KFAWI2NVX5L X-Message-ID-Hash: LVGPVEAOAVAW3YZGX4CU2KFAWI2NVX5L X-MailFrom: tiwai@suse.de X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Tue, 15 Aug 2023 16:00:05 +0200, Andy Shevchenko wrote: > > Can be compressed to a single conditional: > > if (is_playback && copy_from_iter(dma_ptr, bytes, buf) != bytes) I prefer keeping the changes minimalistic in this kind of conversion unless it becomes too ugly. Then it's more clearer what's actually changed. thanks, Takashi