From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2978AC77B75 for ; Mon, 8 May 2023 07:53:59 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id EDF6212DE; Mon, 8 May 2023 09:53:06 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz EDF6212DE DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1683532437; bh=Is2yi1GXjpGEp683Yx8VVVpJ7hhP0Pd2b9hYiB5cfaY=; h=Date:From:To:Subject:In-Reply-To:References:CC:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=EX1CDOUwN/uI4o6cByST0uXWWAMeeG0fO0BF3m6VqrvMCvJnQFWDA6DwaQ0KfIclC ERlcwQ2vT5Q0i2mg7M7xu6swEGwlyJTMN/EO67HMqo1gGsnrB17B/MJMBvjR1jgwZH MY4e9dcrZPceqRl68IYFPgxVKBFTInBPMDbNN+Kw= Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 321F3F8032D; Mon, 8 May 2023 09:52:42 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 57175F8032D; Mon, 8 May 2023 09:52:38 +0200 (CEST) Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 767BAF80087; Mon, 8 May 2023 09:52:30 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 767BAF80087 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=c+fbU/OA; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=E8aHcQZS Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id A779D1F893; Mon, 8 May 2023 07:52:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1683532349; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=R5TP0qM5tkffGrfyIxYL29/3/ZgiCiGBtbr0tWQz3c8=; b=c+fbU/OATMQVAtv7uCO2X5NNHp+OUDFIawoSfn8CjDf50lbAQ4Z6RsKvm+toTYTXXJaXlu yOi4CFYX1bG0H2XAxy8tcojGepSjt4m4xkdYqVmMxcpo7iPDVlDRlCLisg6cQz455fDqfT Ej+OnwVOaevAVlZm7mB++O/LDwa8j3E= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1683532349; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=R5TP0qM5tkffGrfyIxYL29/3/ZgiCiGBtbr0tWQz3c8=; b=E8aHcQZS1lydBQzXYsPzh8mvKGD6sRxsclW1Md1Z7sbKGUB4/YpG8mCzY6ofaTWp/Wc7sB YXMlNbRocIxtffCg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 7D5C213499; Mon, 8 May 2023 07:52:29 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id iPW1HT2qWGSaPwAAMHmgww (envelope-from ); Mon, 08 May 2023 07:52:29 +0000 Date: Mon, 08 May 2023 09:52:29 +0200 Message-ID: <87wn1jdzuq.wl-tiwai@suse.de> From: Takashi Iwai To: perex@perex.cz Subject: Re: [alsa-devel@alsa-project.org: [PATCH 3/5] ASoC: mediatek: mt8195-afe-pcm: Simplify runtime PM during probe] In-Reply-To: <87ednwmssr.wl-tiwai@suse.de> References: <87o7n0mtv9.wl-tiwai@suse.de> <87ednwmssr.wl-tiwai@suse.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Message-ID-Hash: RKDLXPUNP4IEUIXWIZJUECXOQSHFHYKB X-Message-ID-Hash: RKDLXPUNP4IEUIXWIZJUECXOQSHFHYKB X-MailFrom: tiwai@suse.de X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Mark Brown , postmaster@alsa-project.org, sound-open-firmware-owner@alsa-project.org, alsa-devel@alsa-project.org, AngeloGioacchino Del Regno , sound-open-firmware@alsa-project.org X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu, 04 May 2023 09:58:44 +0200, Takashi Iwai wrote: > > On Thu, 04 May 2023 09:35:38 +0200, > Takashi Iwai wrote: > > > > On Thu, 04 May 2023 03:09:45 +0200, > > Mark Brown wrote: > > > > > > Hi, > > > > > > Here's another mail (one of several in this series) that got completely > > > mangled by the alsa-project.org mailman to the point of unusability. I > > > didn't see any response to my last mail about this, is there any news on > > > fixing mailman to not do this? It's extremely disruptive to working > > > with lore. > > > > It seems that alsa-project.org mailman re-sends the post with > > xxx@alsa-project.org address sometimes, indeed. I don't know the > > condition, but now I noticed it while checking the pending approvals. > > And, I guess it happens when a post comes from a non-subscriber. > (But not sure whether this happens always...) > It waits for approval, but also mangles the sender address and co. > This behavior is new after the mail server update. Jaroslav, could you investigate it? I checked again, and it seems that all "approved" posts from non-subscribers are modified to the sender addresses with alsa-project.org. I guess there must be some option to prevent it. Takashi > > Those that appeared in the list wrongly were likely the posts I > > approved without knowing them being superfluously resent ones. > > > > Jaroslav, could you check your mailman configuration? > > So, please check the configuration. As of now, the post from > non-subscriber becomes confusing and unusable for b4. > > > thanks, > > Takashi > > > > > > > thanks, > > > > Takashi > > > > > Thanks, > > > Mark > > > Subject: [PATCH 3/5] ASoC: mediatek: mt8195-afe-pcm: Simplify runtime PM during probe > > > From: AngeloGioacchino Del Regno via Alsa-devel > > > Date: Wed, 03 May 2023 13:34:11 +0200 > > > Message-Id: <168311377075.26.14919941665402646886@mailman-core.alsa-project.org> > > > MIME-Version: 1.0 > > > Content-Transfer-Encoding: 7bit > > > > > > Use devm_pm_runtime_enable() and pm_runtime_resume_and_get() to > > > to simplify the probe function. > > > > > > Signed-off-by: AngeloGioacchino Del Regno > > > --- > > > sound/soc/mediatek/mt8195/mt8195-afe-pcm.c | 22 ++++++++++++---------- > > > 1 file changed, 12 insertions(+), 10 deletions(-) > > > > > > diff --git a/sound/soc/mediatek/mt8195/mt8195-afe-pcm.c b/sound/soc/mediatek/mt8195/mt8195-afe-pcm.c > > > index 9e45efeada55..a54c16e0aa05 100644 > > > --- a/sound/soc/mediatek/mt8195/mt8195-afe-pcm.c > > > +++ b/sound/soc/mediatek/mt8195/mt8195-afe-pcm.c > > > @@ -3179,16 +3179,16 @@ static int mt8195_afe_pcm_dev_probe(struct platform_device *pdev) > > > > > > mt8195_afe_parse_of(afe, pdev->dev.of_node); > > > > > > - pm_runtime_enable(dev); > > > - if (!pm_runtime_enabled(dev)) { > > > - ret = mt8195_afe_runtime_resume(dev); > > > - if (ret) > > > - return ret; > > > - } > > > - > > > /* enable clock for regcache get default value from hw */ > > > afe_priv->pm_runtime_bypass_reg_ctl = true; > > > - pm_runtime_get_sync(dev); > > > + > > > + ret = devm_pm_runtime_enable(dev); > > > + if (ret) > > > + return ret; > > > + > > > + ret = pm_runtime_resume_and_get(dev); > > > + if (ret) > > > + return dev_err_probe(dev, ret, "Failed to resume device\n"); > > > > > > afe->regmap = devm_regmap_init_mmio(&pdev->dev, afe->base_addr, > > > &mt8195_afe_regmap_config); > > > @@ -3238,7 +3238,10 @@ static int mt8195_afe_pcm_dev_probe(struct platform_device *pdev) > > > > > > mt8195_afe_init_registers(afe); > > > > > > - pm_runtime_put_sync(dev); > > > + ret = pm_runtime_put_sync(dev); > > > + if (ret) > > > + return dev_err_probe(dev, ret, "Failed to suspend device\n"); > > > + > > > afe_priv->pm_runtime_bypass_reg_ctl = false; > > > > > > regcache_cache_only(afe->regmap, true); > > > @@ -3248,7 +3251,6 @@ static int mt8195_afe_pcm_dev_probe(struct platform_device *pdev) > > > > > > err_pm_put: > > > pm_runtime_put_sync(dev); > > > - pm_runtime_disable(dev); > > > > > > return ret; > > > } > > > -- > > > 2.40.1