From: Takashi Iwai <tiwai@suse.de>
To: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH] ALSA: emu10k1: minor optimizations
Date: Sat, 22 Apr 2023 09:51:38 +0200 [thread overview]
Message-ID: <87wn24pd6d.wl-tiwai@suse.de> (raw)
In-Reply-To: <20230421172623.1017207-1-oswald.buddenhagen@gmx.de>
On Fri, 21 Apr 2023 19:26:23 +0200,
Oswald Buddenhagen wrote:
> @@ -1245,12 +1245,10 @@ static int _snd_emu10k1_audigy_init_efx(struct snd_emu10k1 *emu)
> icode->code = icode->tram_addr_map + 256;
>
> /* clear free GPRs */
> - for (i = 0; i < 512; i++)
> - set_bit(i, icode->gpr_valid);
> + memset(icode->gpr_valid, 0xff, sizeof(icode->gpr_valid));
>
> /* clear TRAM data & address lines */
> - for (i = 0; i < 256; i++)
> - set_bit(i, icode->tram_valid);
> + memset(icode->tram_valid, 0xff, sizeof(icode->tram_valid));
While those are OK...
> strcpy(icode->name, "Audigy DSP code for ALSA");
> ptr = 0;
> @@ -1886,12 +1884,10 @@ static int _snd_emu10k1_init_efx(struct snd_emu10k1 *emu)
> icode->code = icode->tram_addr_map + 160;
>
> /* clear free GPRs */
> - for (i = 0; i < 256; i++)
> - set_bit(i, icode->gpr_valid);
> + memset(icode->gpr_valid, 0xff, sizeof(icode->gpr_valid));
>
> /* clear TRAM data & address lines */
> - for (i = 0; i < 160; i++)
> - set_bit(i, icode->tram_valid);
> + memset(icode->tram_valid, 0xff, sizeof(icode->tram_valid));
... those bitmap sizes don't match with the previous numbers, so this
is a behavior change.
thanks,
Takashi
prev parent reply other threads:[~2023-04-22 7:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-21 17:26 [PATCH] ALSA: emu10k1: minor optimizations Oswald Buddenhagen
2023-04-22 7:51 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wn24pd6d.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=oswald.buddenhagen@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox