From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E59E0EB64D7 for ; Wed, 28 Jun 2023 09:44:39 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 30DA5822; Wed, 28 Jun 2023 11:43:47 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 30DA5822 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1687945477; bh=06B8+n9uT2jHv/xaG82Jth6xdsIEc0EWos05hmDyM4g=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=hYZQjwr3L0H3fZK5qbgaJee1oNMQBmvQj5qjEMOsyTIfgPrNiYLy++GeueZ1XLMRm vKqBmPdsqjlK9dWpErPpkxss5eYolbduUtuY70VLceDu5b/GfEl6SBE1N7DZlMXoTP g6DDANjSsPhCuSWgSuwDoxtD/TdiOSR+3+fjlp4o= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 8FAD6F80431; Wed, 28 Jun 2023 11:43:25 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 6E637F8027B; Wed, 28 Jun 2023 11:43:24 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 68B6BF8027B; Wed, 28 Jun 2023 11:43:19 +0200 (CEST) Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 5EBDEF80212 for ; Wed, 28 Jun 2023 11:43:06 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 5EBDEF80212 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=s7H7YNr3; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=rWOT6rtk Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id B409221866; Wed, 28 Jun 2023 09:43:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1687945385; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=E0O+gJ+MuLvZfbXkWNTje+JXW2eT1kCnTYOtqKmThKg=; b=s7H7YNr39GB1dh2VeT1CMUqc4as7VfA2j/Qjz6g9N6/jJt6o66VbFGhpcHRJIvtU+ZhakK 4NGkDUiUC3HI4sBgQNutUUu0dlmKoU/GPlbZ2BgwrCsLI2owkeusELf43hsWbKq76gjKk9 kStb5XPpZ0NnbDikYHOxiG/VG9Gq+cw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1687945385; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=E0O+gJ+MuLvZfbXkWNTje+JXW2eT1kCnTYOtqKmThKg=; b=rWOT6rtknF8k0nKRnPjrvvMchpUPd/cXeT/3HG5dN/mSSCD7EYLHZEpT7onIuzaRKmxE1P YOFURbhqO5RldDDw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 917F8138EF; Wed, 28 Jun 2023 09:43:05 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id +vqjIqkAnGRHAgAAMHmgww (envelope-from ); Wed, 28 Jun 2023 09:43:05 +0000 Date: Wed, 28 Jun 2023 11:43:05 +0200 Message-ID: <87y1k3excm.wl-tiwai@suse.de> From: Takashi Iwai To: Takashi Sakamoto Cc: alsa-devel@alsa-project.org Subject: Re: [PATCH] ALSA: fireface: make read-only const array for model names static In-Reply-To: <20230627235406.289970-1-o-takashi@sakamocchi.jp> References: <20230627235406.289970-1-o-takashi@sakamocchi.jp> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Message-ID-Hash: 3CXGSGSU4DXCWGNQXZ3R7EN2PASOIOID X-Message-ID-Hash: 3CXGSGSU4DXCWGNQXZ3R7EN2PASOIOID X-MailFrom: tiwai@suse.de X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed, 28 Jun 2023 01:54:06 +0200, Takashi Sakamoto wrote: > > It is preferable not to populate the constant array for constant strings > on the stack. > > Signed-off-by: Takashi Sakamoto Thanks, applied now. Takashi