From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 51865C77B75 for ; Mon, 8 May 2023 07:39:21 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id BA74B12AC; Mon, 8 May 2023 09:38:28 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz BA74B12AC DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1683531558; bh=dqcjyt95OBvwQOiCr7l8ywoB7nvQzNhBGcaqzzJ6vk0=; h=Date:From:To:Subject:In-Reply-To:References:CC:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=OU+vuOJsSf6tecaAKG22LeiTQ2XpUenCUjKID4ULVT0mDkBoNoadU+HBrz/KySQ+E cm7+qbo73I0FqUtDrV+qtqugmYmkbW1Qv9TBRGHG/kbP45+k4PmVHks951iW2tdZMx i/3ZVpXTnlxr1Rj1HGiSs1UNpgQjuek/5q/cuKoU= Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 38DFAF8032D; Mon, 8 May 2023 09:38:03 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 15EF0F8032D; Mon, 8 May 2023 09:38:00 +0200 (CEST) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 24D1BF80087 for ; Mon, 8 May 2023 09:37:56 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 24D1BF80087 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=mtarhdO3; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=5Kye1D0B Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id C1E4821AC0; Mon, 8 May 2023 07:37:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1683531476; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=YqInM1342hBU+JGe1iQkO4roq6FUOaOXw8p0I5kqNRs=; b=mtarhdO3ra1s5OiLWG+Ju19yqxd1rtL/boRsvziIuReE5Y5zcwq5enIqc20ObcGS+OcJaV 5gRGzfLkxNM/+cuyMoiSofLzsVzQrYChMJG97SzYWdpUB/MTBDDIVTd9qItO9SMZjXYThz kp8V6jhHbDyVGb8TIWtvNj4uKUs+ARk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1683531476; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=YqInM1342hBU+JGe1iQkO4roq6FUOaOXw8p0I5kqNRs=; b=5Kye1D0ByhCf4HBc1zihGsjgV6frE9AoIIYmjc/zQbbkyvtE7SevX713PfNPefVVRQt+YK PyNuxlYbKCpb4pAQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 94F2B1346B; Mon, 8 May 2023 07:37:56 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id r38aI9SmWGRiOAAAMHmgww (envelope-from ); Mon, 08 May 2023 07:37:56 +0000 Date: Mon, 08 May 2023 09:37:56 +0200 Message-ID: <87y1lze0iz.wl-tiwai@suse.de> From: Takashi Iwai To: jack1989s@gmail.com Subject: Re: [PATCH] Sound:last.c: fix code syle trailing white space - modify printk()->netdev_dbg() - Possible unnecessary KERN_INFO removed In-Reply-To: <20230507130021.48112-1-jack1989s@gmail.com> References: <20230507130021.48112-1-jack1989s@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Message-ID-Hash: RK6C4G6VWHJTNGOIF4DOFDHBVXHIVS57 X-Message-ID-Hash: RK6C4G6VWHJTNGOIF4DOFDHBVXHIVS57 X-MailFrom: tiwai@suse.de X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: tiwai@suse.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Sun, 07 May 2023 15:00:21 +0200, jack1989s@gmail.com wrote: > > From: Federico Di Lembo > > Fixing coding style. > > Signed-off-by: Federico Di Lembo In general, we don't take a patch just for white space without any real need. Please do a cleanup together with other real fix or enhancement patches. Also, the use of netdev_dbg() doesn't make sense here at all; the code has nothing to do with the network. Last but not least, you change the printk level by the conversion silently. It's really bad, please don't. If you have to change the printk level, give the convincing explanation. thanks, Takashi > --- > sound/last.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/sound/last.c b/sound/last.c > index f0bb98780e70..b8cfd6ded95d 100644 > --- a/sound/last.c > +++ b/sound/last.c > @@ -11,18 +11,18 @@ static int __init alsa_sound_last_init(void) > { > struct snd_card *card; > int idx, ok = 0; > - > - printk(KERN_INFO "ALSA device list:\n"); > + > + netdev_dbg("ALSA device list:\n"); > for (idx = 0; idx < SNDRV_CARDS; idx++) { > card = snd_card_ref(idx); > if (card) { > - printk(KERN_INFO " #%i: %s\n", idx, card->longname); > + netdev_dbg(" #%i: %s\n", idx, card->longname); > snd_card_unref(card); > ok++; > } > } > if (ok == 0) > - printk(KERN_INFO " No soundcards found.\n"); > + netdev_dbg(" No soundcards found.\n"); > return 0; > } > > -- > 2.34.1 >