From: Takashi Iwai <tiwai@suse.de>
To: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH] ALSA: emu10k1: macro-ize snd_emu10k1_ptr_{read,write}()
Date: Fri, 28 Apr 2023 12:32:51 +0200 [thread overview]
Message-ID: <87y1mcqoto.wl-tiwai@suse.de> (raw)
In-Reply-To: <20230428095941.1706263-1-oswald.buddenhagen@gmx.de>
On Fri, 28 Apr 2023 11:59:41 +0200,
Oswald Buddenhagen wrote:
>
> The idea to encode the bitfield manipulation in the register address is
> quite clever, but it's somewhat wasteful to do these calculations at
> runtime, given that they are all constants. Change that.
>
> The added bitfield manipulation macros will be used separately as well.
>
> Signed-off-by: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
JFYI, I postpone applying this and the rest emu10k1 changes, since
it's in a merge window now. They will be reviewed and merged for 6.5
after the 6.4 merge window.
The patch "[PATCH RESEND] ALSA: emu10k1: use more existing defines
instead of open-coded numbers" was already taken as it was a resent
patch.
So, if you have patches that fix bugs and should be applied soonish,
submit those.
thanks,
Takashi
next prev parent reply other threads:[~2023-04-28 10:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-28 9:59 [PATCH] ALSA: emu10k1: macro-ize snd_emu10k1_ptr_{read,write}() Oswald Buddenhagen
2023-04-28 10:32 ` Takashi Iwai [this message]
2023-05-08 7:14 ` Takashi Iwai
2023-05-08 11:14 ` Oswald Buddenhagen
2023-05-08 11:40 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y1mcqoto.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=oswald.buddenhagen@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox