From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8555CC7618E for ; Sat, 22 Apr 2023 07:47:57 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id A1D0DE98; Sat, 22 Apr 2023 09:47:04 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz A1D0DE98 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1682149674; bh=ih6ZplLS+K97zu+Y03nU2wpSEvOqOtlODfuI+CbjbrI=; h=Date:From:To:Subject:In-Reply-To:References:CC:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=veEgrC6wcFJHVtDkQwQi/9YyRCaWD/mtaaEMNS9OZh8wewpWDU4HCWYcmsPjRCdPm 4GHSMpdxhoXO2VL/WABJ9iF7hOSva0pA3GwRexlGOmtR4Hhs4xnjrytUWTPXH0QmRH T1xJDxeJbqDdCSnxJGoeGinAjKNZHHOhtL7S0kc4= Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 13E91F80053; Sat, 22 Apr 2023 09:46:39 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 75D71F80155; Sat, 22 Apr 2023 09:46:35 +0200 (CEST) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id D7DC4F80053 for ; Sat, 22 Apr 2023 09:46:25 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz D7DC4F80053 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=Auq4FVJa; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=7je044UM Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 4AFAD21983; Sat, 22 Apr 2023 07:46:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1682149585; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=v/bm8DNKrOZ55Kn9YREVor2KGgcsFXgxiKGwir2d9AY=; b=Auq4FVJarFqGzkf1QIXuTuJkWQRQas7akChIRukw0sN8gAnv50QgcZNbL7wYmIAMQV3gsk RVdD1v/DwXei3FgZmwnfDlJ4OIIW6O9MGbq/xHObf+9vFKv1aBM0jP8GxBZO9as6IaZATI MXRFaz3ksfofCrfxm+PEaBJmDDDqtcI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1682149585; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=v/bm8DNKrOZ55Kn9YREVor2KGgcsFXgxiKGwir2d9AY=; b=7je044UMzwCUKa/YBeP834Rd8wCp5Qg3xVWOHxn8mrCm3hYycQsZu7JWG2aB9Hlp2NDO9T 7SfxLyDESKJbQtCA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 2701513591; Sat, 22 Apr 2023 07:46:25 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id yC+cCNGQQ2T9JAAAMHmgww (envelope-from ); Sat, 22 Apr 2023 07:46:25 +0000 Date: Sat, 22 Apr 2023 09:46:24 +0200 Message-ID: <87y1mkpdf3.wl-tiwai@suse.de> From: Takashi Iwai To: Oswald Buddenhagen Subject: Re: [PATCH] ALSA: emu10k1: fix error codes In-Reply-To: <20230421172623.1017222-1-oswald.buddenhagen@gmx.de> References: <20230421172623.1017222-1-oswald.buddenhagen@gmx.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Message-ID-Hash: XYMLE25K3E3FHU4QXSKICW7U7OCWYTFX X-Message-ID-Hash: XYMLE25K3E3FHU4QXSKICW7U7OCWYTFX X-MailFrom: tiwai@suse.de X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: alsa-devel@alsa-project.org X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri, 21 Apr 2023 19:26:23 +0200, Oswald Buddenhagen wrote: > > One might argue that this potentially breaks user space, but a) this is > just one driver among many, so it seems unlikely that someone would > expect (only) the broken codes and b) it seems unlikely that someone > would check these syscalls for particular errors at all, rather than > just logging them (this might be debatable for the voice allocator > calls). > > Signed-off-by: Oswald Buddenhagen I find this is too risky for really little win. The error code is returned to user space in quite many cases; e.g. the voice allocator is called from PCM hw_params, too, and that's most of user-space programs do actually check. It could be a surprise if it's changed without much reason, may trigger unexpected behavior changes. Of course, if the error code must be corrected, we can fix it. But I don't see it in this patch description. thanks, Takashi