From: Takashi Iwai <tiwai@suse.de>
To: Stefan Binding <sbinding@opensource.cirrus.com>
Cc: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
<alsa-devel@alsa-project.org>, <linux-kernel@vger.kernel.org>,
<patches@opensource.cirrus.com>
Subject: Re: [PATCH RESEND v1 2/3] ALSA: hda: cs35l41: Fix endian conversions
Date: Mon, 05 Jun 2023 09:21:24 +0200 [thread overview]
Message-ID: <87zg5eidcb.wl-tiwai@suse.de> (raw)
In-Reply-To: <20230525135955.2108140-3-sbinding@opensource.cirrus.com>
On Thu, 25 May 2023 15:59:54 +0200,
Stefan Binding wrote:
>
> @@ -379,10 +379,10 @@ static int cs35l41_save_calibration(struct cs35l41_hda *cs35l41)
>
> /* Calibration can only be applied whilst the DSP is not running */
> ret = cs35l41_apply_calibration(cs35l41,
> - cpu_to_be32(cl->calAmbient),
> - cpu_to_be32(cl->calR),
> - cpu_to_be32(cl->calStatus),
> - cpu_to_be32(cl->calR + 1));
> + (__be32)cpu_to_be32(cl->calAmbient),
> + (__be32)cpu_to_be32(cl->calR),
> + (__be32)cpu_to_be32(cl->calStatus),
> + (__be32)cpu_to_be32(cl->calR + 1));
Do we really need those cast? Even if yes, it must be with __force
prefix for the endian cast in general.
thanks,
Takashi
next prev parent reply other threads:[~2023-06-05 7:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-25 13:59 [PATCH RESEND v1 0/3] Fixes and cleanup for CS35L41 HDA Stefan Binding
2023-05-25 13:59 ` [PATCH RESEND v1 1/3] ALSA: hda: cs35l41: Clean up Firmware Load Controls Stefan Binding
2023-05-25 13:59 ` [PATCH RESEND v1 2/3] ALSA: hda: cs35l41: Fix endian conversions Stefan Binding
2023-06-05 7:21 ` Takashi Iwai [this message]
2023-06-05 12:50 ` Stefan Binding
2023-06-05 13:17 ` Takashi Iwai
2023-06-05 15:23 ` Stefan Binding
2023-05-25 13:59 ` [PATCH RESEND v1 3/3] ALSA: hda/realtek: Delete cs35l41 component master during free Stefan Binding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zg5eidcb.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=perex@perex.cz \
--cc=sbinding@opensource.cirrus.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox