From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5F9DEC77B7F for ; Fri, 12 May 2023 09:02:29 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 8CD8B1E0; Fri, 12 May 2023 11:01:37 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 8CD8B1E0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1683882147; bh=Oyr2UIGE5GaW5mQPFlc3cgRgGfoM6r0h32gcDg3m3uU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=kHTiMC27O6ugY9b7rc8dzUteHQZUCXSaRYJ5E8/tTJ80LTcNoM4ju+MN9xvuZXmoY RGwey4R5vYVtrf7yLKTJa2kUTVDSb9VKBjgFLAtfbfMZ2KryOIMrH/X3swyFUjPEpA 36z1WKIwfsjOBZ8fw4fFlZyYRSrtmCWeHxEY/rZY= Received: by alsa1.perex.cz (Postfix, from userid 50401) id A1359F80548; Fri, 12 May 2023 11:01:11 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 419E6F80534; Fri, 12 May 2023 11:01:11 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id D4112F8052E; Fri, 12 May 2023 11:01:07 +0200 (CEST) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 6A5EAF80087 for ; Fri, 12 May 2023 11:01:02 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 6A5EAF80087 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=kXji4Qkf; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=7uJLTg3v Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id B788C227A4; Fri, 12 May 2023 09:01:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1683882061; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mXNd6eQ6X7huzKiDKsIcyDIaUBR8M8NVClaH/h4XHhM=; b=kXji4QkfgCIqbDquhJPxJaXbA3YnaP15x8HguHALymX9Xuwx5zn304e6ssS/34V6Vd/qba AzM9FEKNZfLmMhUYFgHsJGqZZmwpUG7HQT/tcX2cwKdKUCXfv3DgOWGVKION8+KHs2A39i 2g2RzB0BgPgLGm1iyq+P5uq9Ecg6B7k= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1683882061; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mXNd6eQ6X7huzKiDKsIcyDIaUBR8M8NVClaH/h4XHhM=; b=7uJLTg3vbHLZc4OjX7Impxon0XJIJTCmLzprZDXeUnN9TwkTVFgrqoIs/vq9i3NrNROjiC EN0zY4O+rgR0IYDQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 9C85713499; Fri, 12 May 2023 09:01:01 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id TVY1JU0AXmQbMwAAMHmgww (envelope-from ); Fri, 12 May 2023 09:01:01 +0000 Date: Fri, 12 May 2023 11:01:01 +0200 Message-ID: <87zg69appu.wl-tiwai@suse.de> From: Takashi Iwai To: Olliver Schinagl Cc: alsa-devel@alsa-project.org Subject: Re: snd_hda_codec_cirrus kernel oops In-Reply-To: <64d95eb0-dbdb-cff8-a8b1-988dc22b24cd@schinagl.nl> References: <64d95eb0-dbdb-cff8-a8b1-988dc22b24cd@schinagl.nl> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Message-ID-Hash: L677SGXWOF642YNJMY77VA4VOXEQGYHN X-Message-ID-Hash: L677SGXWOF642YNJMY77VA4VOXEQGYHN X-MailFrom: tiwai@suse.de X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu, 11 May 2023 17:12:23 +0200, Olliver Schinagl wrote: > > Hey list, > > I've noticed the following crash since the last few days, causing > audio to no longer to work. It could be related to me updating the > firmware (bios) not too long ago (I load Mac OS every few months via > an external drive) which caused the firmware to be updated. Or, it was > a kernel update, that came along every few weeks. > > I'll try to find my archlinux bugzilla stuff, to report it there as > well, but I don't think they are actively patching the sound stuff. > > The last commit I'm seeing on `patch_cirrus.c` seems to be from aug > 2022, so that can't be it, though incidentally, the change is with > regards to support for iMac 12,1 model, which is interesting as the > number is the same. > > I understand you guys probably get tons of bug reports, but best to > leave it here, just in case. > > [ 90.497004] CPU: 3 PID: 343 Comm: modprobe Not tainted > 6.3.1-arch2-1 #1 4c16b0b90f71a940c7f1bb2eb00cdd9db2a83452 > [ 90.497008] Hardware name: Apple > Inc. MacBookPro12,1/Mac-E43C1C25D4880AD6, BIOS 481.0.0.0.0 01/12/2023 > [ 90.497010] RIP: 0010:get_line_out_pfx+0x2dd/0x3e0 > [snd_hda_codec_generic] Can you try to decode which line does it hit? Also, as a blind shot, does the patch below work around the bug? thanks, Takashi -- 8< -- --- a/sound/pci/hda/hda_generic.c +++ b/sound/pci/hda/hda_generic.c @@ -1182,7 +1182,7 @@ static const char *get_line_out_pfx(struct hda_codec *codec, int ch, /* multi-io channels */ if (ch >= cfg->line_outs) - return channel_name[ch]; + goto fixed_names; switch (cfg->line_out_type) { case AUTO_PIN_SPEAKER_OUT: @@ -1234,8 +1234,9 @@ static const char *get_line_out_pfx(struct hda_codec *codec, int ch, if (cfg->line_outs == 1 && !spec->multi_ios) return "Line Out"; + fixed_names: if (ch >= ARRAY_SIZE(channel_name)) { - snd_BUG(); + codec_err(codec, "Too many channels in %s: %d\n", __func__, ch); return "PCM"; }