From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 928CFC77B75 for ; Fri, 5 May 2023 09:32:45 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id D3B8B2C1C; Fri, 5 May 2023 11:31:52 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz D3B8B2C1C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1683279162; bh=q54GUt1lCYkKR9+YmSM5Ie5t9NUwD/74LH4S2PquEhY=; h=Date:From:To:Subject:In-Reply-To:References:CC:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=UVNiJ2r4kb84XcpewB1CEQFljZ+OAEYio4yfTnRsWKVVA1TczpjFA/jijLo87kv4Q k2pW7R2N31lmGBawbwOi+R6Ppnqg5UgF7oCv1JAsTtQkgqkxENpZ5K3xZ5H97OMjOr GH6FZj9YbPIRcMEm0WORI9mqjs2Ff7MuEyZ3vM3k= Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id A8D30F804B1; Fri, 5 May 2023 11:31:27 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id E0A83F8052D; Fri, 5 May 2023 11:31:22 +0200 (CEST) Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id E3896F804B1 for ; Fri, 5 May 2023 11:31:17 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz E3896F804B1 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=SSfkhjz1; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=OBG3bHhU Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 5DF4F2218E; Fri, 5 May 2023 09:31:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1683279077; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=s8j0OGgkE7eOUpox6xaEYAUhJAdohZ5OCFdGwZl62ic=; b=SSfkhjz1ML1pJMR1IzDlVeWhPRBaeq6XLm94heG2Gjcu2PyTZcJcXUnHUK7yUEzW+2RIz7 sRz0h3nQHYYIe3ntPipEhKGnN2imbpiUcmh45M7ckIHIR6d6PshK9ysNtX/0h9gwqXvQ4h eIZTdZAE+k3z64sGb20UGLUzf3PrX1E= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1683279077; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=s8j0OGgkE7eOUpox6xaEYAUhJAdohZ5OCFdGwZl62ic=; b=OBG3bHhU8eti4ZI8RriuEx7/ETRm5xNBKpzIt81GPyUfZNwhzHxczLi75oD/C8BKfFA8tq sV/oaLh0luyTgMAQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 37B2413488; Fri, 5 May 2023 09:31:17 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id nDKUDOXMVGRNXQAAMHmgww (envelope-from ); Fri, 05 May 2023 09:31:17 +0000 Date: Fri, 05 May 2023 11:31:16 +0200 Message-ID: <87zg6ji0pn.wl-tiwai@suse.de> From: Takashi Iwai To: Jaroslav Kysela Subject: Re: [PATCH 1/5] ALSA: pcm: Revert "ALSA: pcm: rewrite snd_pcm_playback_silence()" In-Reply-To: <20230505073813.1219175-2-perex@perex.cz> References: <20230505073813.1219175-1-perex@perex.cz> <20230505073813.1219175-2-perex@perex.cz> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Message-ID-Hash: W6UOSVRIJBXUZ3TZFCHARIJ3QOWW7GM7 X-Message-ID-Hash: W6UOSVRIJBXUZ3TZFCHARIJ3QOWW7GM7 X-MailFrom: tiwai@suse.de X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: ALSA development , Oswald Buddenhagen , Jeff Chua X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri, 05 May 2023 09:38:09 +0200, Jaroslav Kysela wrote: > > This reverts commit 9f656705c5faa18afb26d922cfc64f9fd103c38d. > > There is a regression (the top-up mode). Unfortunately, the patch > provided from the author of this commit is not easy for the review. > > Keep the update and new comments in headers. > > Signed-off-by: Jaroslav Kysela Better to add Reported-by and the reference for the original thread reporting the regression, as well as the Fixes tag. I can cook up it by myself, too. Takashi