From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 42FCDC54E94 for ; Wed, 25 Jan 2023 08:37:09 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 915A59F6; Wed, 25 Jan 2023 09:36:17 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 915A59F6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1674635827; bh=WbPkbQAZ9P2xmLREm8w6DO7m9349kVYrLHBhm9+rA60=; h=Date:From:To:Subject:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=b7nOL0AbRulFFJvye6gAikgcqDYc4vMk+Kr/Q4R8FKJaHpudBcni6NUeboepTpYmY gjilo4Z9MFJajAUhKFkVp0acywS7hLrx8t8mlvXLAZIPfd0u7HD5E6SiY+Vq3DYW77 Brl8qYnL7Symbv/sxsyu9XJHVzuFkqksqsE9v9UE= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 4067BF802E8; Wed, 25 Jan 2023 09:36:17 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 1F831F804FC; Wed, 25 Jan 2023 09:35:12 +0100 (CET) Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id A0F64F800FB for ; Wed, 25 Jan 2023 09:35:09 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz A0F64F800FB Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=iVxYPi2C; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=4EEvO/Qo Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 4D04D20285; Wed, 25 Jan 2023 08:35:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1674635709; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=lQ0jctwPTNkmDUNtF4vMSoW4Azggy1ZZvdqA5S1CogE=; b=iVxYPi2CWtJKh815Zk4gpov2AgwL6D9/JiAfIFUF8lHwYMj63V5elLRpBqTazoiiWLXK+R zvRdLaEpAwNWmSPEr+jYOjRnP0IZ3SZ/FJ3+HZOucdtX3zRdMCskJxMbMjRJ4ZLqNHRt0Q 3bNSWF4tiZohKsz2FR4nyGGyznD0rNs= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1674635709; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=lQ0jctwPTNkmDUNtF4vMSoW4Azggy1ZZvdqA5S1CogE=; b=4EEvO/QoFJw3Kv0I+VjCHiLk4be0pxaOkp2TJoCqiBa21YP1Mkx1HoZKe07hRHGMF5oqpM ORDicHkAjcDazVAw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 254D01339E; Wed, 25 Jan 2023 08:35:09 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id d7DvB73p0GOVewAAMHmgww (envelope-from ); Wed, 25 Jan 2023 08:35:09 +0000 Date: Wed, 25 Jan 2023 09:35:08 +0100 Message-ID: <87zga7c8qr.wl-tiwai@suse.de> From: Takashi Iwai To: Dawei Li Subject: Re: [PATCH v2] ALSA: aoa: make remove callback of soundbus driver void returned In-Reply-To: References: User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, tiwai@suse.com, johannes@sipsolutions.net, linuxppc-dev@lists.ozlabs.org Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Fri, 06 Jan 2023 16:17:46 +0100, Dawei Li wrote: > > Since commit fc7a6209d571 ("bus: Make remove callback return void") > forces bus_type::remove be void-returned, it doesn't make much sense > for any bus based driver implementing remove callbalk to return > non-void to its caller. > > As such, change the remove function for soundbus based drivers to > return void. > > Signed-off-by: Dawei Li Applied now, thanks. Takashi