From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BE06CC43334 for ; Fri, 17 Jun 2022 08:43:51 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 241A01B1C; Fri, 17 Jun 2022 10:42:59 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 241A01B1C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1655455429; bh=pOc1ibUnA0j86MZVvjZQ8mTOiBDNpmlwfnok/2Yh2ug=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=s452QJvywt0qrSBfsaAeibMNSDgUP/LuzpUHB4lnzz9HB8Em4SOprIMeQsvyfIZfV uU4wEoe9F/KUA+k6dQ0IenOpKCoorgZKN5/gUX7M5ZJSoyD2duB0Zn6NEDtI0VCZIz dopzEcnC8Ccq+IMF8wlZ9bKb7fs5joRtnu2qQ7jI= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id AA015F800D3; Fri, 17 Jun 2022 10:42:58 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id BDD01F80159; Fri, 17 Jun 2022 10:42:56 +0200 (CEST) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 362FBF800B9 for ; Fri, 17 Jun 2022 10:42:52 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 362FBF800B9 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="nnk52/hL"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="t5D7PuSk" Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id E64A521E53; Fri, 17 Jun 2022 08:42:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1655455371; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=k04bjqg5q9YK0UT1SaQdcTTbluVyt4dFb8icJOEwxDo=; b=nnk52/hLN0Eh+pVMj/BEETAABulBIPjftCZWe2krxXuaRGk8vzjX8+PWfNk9l5psedmHxI tby/3UNkuDt04KP6MbMyMhge+mApMbXXJuNXJwZ8xUY8zdc/S5FC+tTti1XBFYHpPixag1 r5ys4Ivu1wA6mueTV8+Y13Zd0ibR2qo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1655455371; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=k04bjqg5q9YK0UT1SaQdcTTbluVyt4dFb8icJOEwxDo=; b=t5D7PuSkkmwh1OEHpwIzAHYSFY5LKvTn90Y7Y+UK0wScma72ieOqEzw+DfisaXlnalq59p ULIBUiU4fqwiBgDg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id C2E3313458; Fri, 17 Jun 2022 08:42:51 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id OI3NLYs+rGIiHAAAMHmgww (envelope-from ); Fri, 17 Jun 2022 08:42:51 +0000 Date: Fri, 17 Jun 2022 10:42:51 +0200 Message-ID: <87zgib1y0k.wl-tiwai@suse.de> From: Takashi Iwai To: Takashi Sakamoto Subject: Re: [PATCH v2 0/3] firewire: fix minor issues In-Reply-To: References: <20220615121505.61412-1-o-takashi@sakamocchi.jp> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Cc: alsa-devel@alsa-project.org, stefanr@s5r6.in-berlin.de, linux1394-devel@lists.sourceforge.net X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Thu, 16 Jun 2022 02:21:42 +0200, Takashi Sakamoto wrote: > > Hi, > > I realized that the second patch still includes a bug that shorter > buffer is allocated for block request than received length since the > computation is aligned to 4 without care of remainder. > > Actually in the case of block request, the length is not necessarily > multiples of 4 and the packet payload has enough size of field with > padding to be aligned to 4, according to 1394 OHCI specification. In the > implementation of firewire-core driver, the field is copied without > the padding. > > Please abandon them. I'm sorry to trouble you. So this implies that the type declaration of data[] rather looks wrong? Takashi