From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6CE5EC04A6A for ; Mon, 7 Aug 2023 14:59:26 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 95B7F86F; Mon, 7 Aug 2023 16:58:34 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 95B7F86F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1691420364; bh=lK5NaO7oefA5g11ZXsxw+6NSKHBHesJlzzBUmcoECcY=; h=Date:Subject:To:Cc:References:From:In-Reply-To:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=H9Daq8tivY9aU4C2jCseRLl0mYq7W6QtdDWG4/Vd7Mz4KC+suRa1Ztq2JvdvlOaID nq0F0FYuhB3SvT6u7SQd8VhLBWLF954PwJqq14JVl7l6z9Y2LDC4vSa9WFNgsQT+Ck 9SCc5MGG0KP5EdXhUfO7YJPcnF8MAUq7sCXtZMe0= Received: by alsa1.perex.cz (Postfix, from userid 50401) id B043EF805AD; Mon, 7 Aug 2023 16:57:02 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 3B644F805AC; Mon, 7 Aug 2023 16:57:02 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 6C3ADF80570; Mon, 7 Aug 2023 16:56:54 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id AB7B7F8051E; Mon, 7 Aug 2023 16:56:47 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz AB7B7F8051E Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=YZCOkCvf DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1691420210; x=1722956210; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=lK5NaO7oefA5g11ZXsxw+6NSKHBHesJlzzBUmcoECcY=; b=YZCOkCvfpIXFhs90SuMHPyGRxFczU+4L10l1jbJwkweAP5Wczg6mGKWT ElqeHhNt1D7j8XTma9Tq7VoFzfihaN883Ztfvd1ahIN2pOEdPSFC+1mlk rj0Ti+JhOo9BPk+PDHaw+uMV8OwarOVU5r/rBnlcrdtJTdE01xFyHkI9S FfIXeCYkQy6LfA9pWbDMS0BQKtX2yb2fbfT4Y9mMT4N1dkdKCAeb6i6Jc DFO7WQP9QD+8QqDG/vJ+zEXDEhEUlw/xdu3/QgmO7HD2BgeJfbOI5J62u C99CcUTqcrRJ5z6r4dGU6LfBK+hD2vWWYWpaVN+luK8n6b2YWAVYI6I6V A==; X-IronPort-AV: E=McAfee;i="6600,9927,10795"; a="434410622" X-IronPort-AV: E=Sophos;i="6.01,262,1684825200"; d="scan'208";a="434410622" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Aug 2023 07:56:42 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10795"; a="1061623884" X-IronPort-AV: E=Sophos;i="6.01,262,1684825200"; d="scan'208";a="1061623884" Received: from hweelee-mobl.amr.corp.intel.com (HELO [10.209.181.215]) ([10.209.181.215]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Aug 2023 07:56:41 -0700 Message-ID: <880a953d-bc81-5f00-7ad6-bbcf6eaac856@linux.intel.com> Date: Mon, 7 Aug 2023 09:17:43 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Firefox/102.0 Thunderbird/102.13.0 Subject: Re: [PATCH v3 7/9] ALSA: hda/intel: Move snd_hdac_i915_init to before probe_work. Content-Language: en-US To: Maarten Lankhorst , alsa-devel@alsa-project.org Cc: Maarten Lankhorst , Jaroslav Kysela , Takashi Iwai , Cezary Rojewski , Liam Girdwood , Peter Ujfalusi , Bard Liao , Ranjani Sridharan , Kai Vehmanen , Mark Brown , Daniel Baluta , linux-kernel@vger.kernel.org, sound-open-firmware@alsa-project.org References: <20230807090045.198993-1-maarten.lankhorst@linux.intel.com> <20230807090045.198993-8-maarten.lankhorst@linux.intel.com> From: Pierre-Louis Bossart In-Reply-To: <20230807090045.198993-8-maarten.lankhorst@linux.intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Message-ID-Hash: BWLRBVL7KK72YBVAIREP6JFHWXFDE3R5 X-Message-ID-Hash: BWLRBVL7KK72YBVAIREP6JFHWXFDE3R5 X-MailFrom: pierre-louis.bossart@linux.intel.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: <> List-Archive: <> List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 8/7/23 04:00, Maarten Lankhorst wrote: > Now that we can use -EPROBE_DEFER, it's no longer required to spin off > the snd_hdac_i915_init into a workqueue. > > Use the -EPROBE_DEFER mechanism instead, which must be returned in the > probe function. > > Changes since v1: > - Use dev_err_probe() > - Don't move probed_devs bitmap unnecessarily. (tiwai) > - Move snd_hdac_i915_init slightly upward, to ensure > it's always initialised before vga-switcheroo is called. same issue with changes. > > Signed-off-by: Maarten Lankhorst > Reviewed-by: Kai Vehmanen Reviewed-by: Pierre-Louis Bossart