From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4A3F4E7542F for ; Tue, 3 Oct 2023 07:16:52 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 7E49AAE9; Tue, 3 Oct 2023 09:15:59 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 7E49AAE9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1696317409; bh=EVtKTrfrbj1XCTOf55slOIXSe1B7F9FizV0UJfRCpN0=; h=Date:Subject:From:To:Cc:References:In-Reply-To:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=AOmQ3j1kPXZJeTHeejECSjJH+rNVDn3ORLU4fm40fOUhv2K9/S2Gpp7t97vZhlvj/ pKefFUWRf3wjq8uaKZGUwOEdUmMfKrSwZzOjRuXW0V4fNdR9hWekK1ePpOq8w5eDcp OM/eLqo03zdDol5MA/U9ivnFsIz///kbW3FGZciE= Received: by alsa1.perex.cz (Postfix, from userid 50401) id EBACBF8055C; Tue, 3 Oct 2023 09:15:30 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 1DF58F8047D; Tue, 3 Oct 2023 09:15:30 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 2A38BF8047D; Tue, 3 Oct 2023 09:15:25 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 49A82F80130; Tue, 3 Oct 2023 09:15:18 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 49A82F80130 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=NHiTDOol DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1696317321; x=1727853321; h=message-id:date:mime-version:subject:from:to:cc: references:in-reply-to:content-transfer-encoding; bh=EVtKTrfrbj1XCTOf55slOIXSe1B7F9FizV0UJfRCpN0=; b=NHiTDOolN99YlEj6yeGtT/WMIjvA2zNgkhgCn7YpD0dwEcrkl+YsKGW1 bi++xaF6NjVu4HiPQSIB9GYqT8orqnvUs+PoTHt6eqM8rad71ei/gNWth woQT0LL0Ahsq2ewqYIyDH6xVrCbDqyb6nVBo3N7EmuJSrU6tDoUFK3PlP l5FnvmoKA46gq4tOgzFqsSLgVl97nVbYl6jd1Eq9RSqyonDw8YriE1hoZ yZ8ua67zbot4pHAKyDokDsWEspzHaR5Lv6RZcPnr9GDw3sCZ4+oDJ57s7 To6m5Cl55bfrcGJGS8sMjjJeC06GdPcteYNhVXqkcvRLsI0dgrsXkvEGS g==; X-IronPort-AV: E=McAfee;i="6600,9927,10851"; a="385632750" X-IronPort-AV: E=Sophos;i="6.03,196,1694761200"; d="scan'208";a="385632750" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Oct 2023 00:15:15 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10851"; a="816579985" X-IronPort-AV: E=Sophos;i="6.03,196,1694761200"; d="scan'208";a="816579985" Received: from aslawinx-mobl.ger.corp.intel.com (HELO [10.94.0.91]) ([10.94.0.91]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Oct 2023 00:15:08 -0700 Message-ID: <881c99b5-f64e-4c74-1420-8eec08cca0ce@linux.intel.com> Date: Tue, 3 Oct 2023 09:15:06 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH v5 10/12] ASoC: Intel: Skylake: Move snd_hdac_i915_init to before probe_work. Content-Language: en-US From: =?UTF-8?Q?Amadeusz_S=c5=82awi=c5=84ski?= To: Maarten Lankhorst , alsa-devel@alsa-project.org Cc: Mark Brown , Kai Vehmanen , Jaroslav Kysela , Takashi Iwai , Cezary Rojewski , Pierre-Louis Bossart , Liam Girdwood , Peter Ujfalusi , Bard Liao , Ranjani Sridharan , Daniel Baluta , linux-kernel@vger.kernel.org, sound-open-firmware@alsa-project.org References: <20230929145123.233838-1-maarten.lankhorst@linux.intel.com> <20231002165202.17863-1-maarten.lankhorst@linux.intel.com> <8a506cfa-7274-b760-1fc1-60d0e5b75a8b@linux.intel.com> In-Reply-To: <8a506cfa-7274-b760-1fc1-60d0e5b75a8b@linux.intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Message-ID-Hash: DUEVNEM7KCSIUQCMRDFXFR26I3B7R4CE X-Message-ID-Hash: DUEVNEM7KCSIUQCMRDFXFR26I3B7R4CE X-MailFrom: amadeuszx.slawinski@linux.intel.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 10/3/2023 8:55 AM, Amadeusz Sławiński wrote: > On 10/2/2023 6:52 PM, Maarten Lankhorst wrote: >> Now that we can use -EPROBE_DEFER, it's no longer required to spin off >> the snd_hdac_i915_init into a workqueue. It's likely the whole workqueue >> can be destroyed, but I don't have the means to test this. >> >> Removing the workqueue would simplify init even further, but is left >> as exercise for the reviewer. >> >> Signed-off-by: Maarten Lankhorst >> Acked-by: Mark Brown >> Reviewed-by: Kai Vehmanen >> Reviewed-by: Amadeusz Sławiński >> --- > > Isn't the convention that your Signed-off should be last when you are > sending the patches? Or does it only apply to Signed-off lines > themselves and other lines can be anywhere? > And rereading kernel documentation, it really seems to be a bit ambiguous, well ignore the comment then.