From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Mark Brown <broonie@kernel.org>
Cc: tiwai@suse.de, alsa-devel@alsa-project.org
Subject: Re: [PATCH 2/2] ASoC: Intel: atom: fix 'defined but not used' warning
Date: Wed, 1 Jul 2020 13:59:43 -0500 [thread overview]
Message-ID: <882693f9-554a-2ec2-8960-af33e02f807e@linux.intel.com> (raw)
In-Reply-To: <20200701184450.GB3776@sirena.org.uk>
On 7/1/20 1:44 PM, Mark Brown wrote:
> On Wed, Jul 01, 2020 at 01:37:16PM -0500, Pierre-Louis Bossart wrote:
>> Fix W=1 warning. The VOIP controls were not used in the mainline but
>> in special versions of Android. Keep and use __maybe_used to make
>> warning go away.
>
> Why not just remove them?
You'll see a lot of patches where tools report variables/tables as not
used, or not really necessary, it's not clear to me how to deal with
such cases, so I preferred to err on the side of caution.
I honestly don't know if those products are maintained and by whom. I
personally have no issue removing this variable, but I've been surprised
to see 'old' products get a kernel upgrade so when in doubt...
next prev parent reply other threads:[~2020-07-01 19:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-01 18:37 [PATCH 0/2] ASoC: Intel: atom: fix kernel-doc and W=1 warnings Pierre-Louis Bossart
2020-07-01 18:37 ` [PATCH 1/2] ASoC: Intel: atom: fix kernel-doc Pierre-Louis Bossart
2020-07-01 18:37 ` [PATCH 2/2] ASoC: Intel: atom: fix 'defined but not used' warning Pierre-Louis Bossart
2020-07-01 18:44 ` Mark Brown
2020-07-01 18:59 ` Pierre-Louis Bossart [this message]
2020-07-01 22:23 ` [PATCH 0/2] ASoC: Intel: atom: fix kernel-doc and W=1 warnings Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=882693f9-554a-2ec2-8960-af33e02f807e@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).