From: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
To: Mark Brown <broonie@kernel.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Syed Saba Kareem <Syed.SabaKareem@amd.com>,
Vijendar Mukunda <Vijendar.Mukunda@amd.com>,
Arnd Bergmann <arnd@arndb.de>,
Randy Dunlap <rdunlap@infradead.org>,
Charles Keepax <ckeepax@opensource.cirrus.com>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
kernel@collabora.com
Subject: Re: [PATCH v2 3/3] ASoC: amd: vangogh: Add support for NAU8821/MAX98388 variant
Date: Thu, 6 Jul 2023 00:31:53 +0300 [thread overview]
Message-ID: <8a404cb2-ef2d-4df5-1f91-e5562f8204af@collabora.com> (raw)
In-Reply-To: <a414b971-381b-4695-9ba4-d2c777bff330@sirena.org.uk>
On 7/5/23 19:16, Mark Brown wrote:
> On Wed, Jul 05, 2023 at 04:43:41PM +0300, Cristian Ciocaltea wrote:
>
>> +static int acp5x_max98388_hw_params(struct snd_pcm_substream *substream,
>> + struct snd_pcm_hw_params *params)
>> +{
>> + struct snd_soc_pcm_runtime *rtd = asoc_substream_to_rtd(substream);
>> + struct snd_soc_dai *dai = snd_soc_card_get_codec_dai(rtd->card,
>> + ACP5X_MAX98388_DAI_NAME);
>> + int ret;
>> +
>> + ret = snd_soc_dai_set_fmt(dai,
>> + SND_SOC_DAIFMT_CBS_CFS | SND_SOC_DAIFMT_I2S |
>> + SND_SOC_DAIFMT_NB_NF);
>> + if (ret < 0)
>> + dev_err(dai->dev, "Failed to set format: %d\n", ret);
>> +
>> + return ret;
>> +}
>
> This never varies, why not just set it up statically in the dai_link?
Right, will handle this in v3.
Thanks,
Cristian
prev parent reply other threads:[~2023-07-05 21:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-05 13:43 [PATCH v2 0/3] AMD Vangogh support for NAU8821/MAX98388 Cristian Ciocaltea
2023-07-05 13:43 ` [PATCH v2 1/3] ASoC: amd: vangogh: Make use of DRV_NAME Cristian Ciocaltea
2023-07-05 13:43 ` [PATCH v2 2/3] ASoC: amd: vangogh: Use dmi_first_match() for DMI quirk handling Cristian Ciocaltea
2023-07-05 13:43 ` [PATCH v2 3/3] ASoC: amd: vangogh: Add support for NAU8821/MAX98388 variant Cristian Ciocaltea
2023-07-05 16:16 ` Mark Brown
2023-07-05 21:31 ` Cristian Ciocaltea [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8a404cb2-ef2d-4df5-1f91-e5562f8204af@collabora.com \
--to=cristian.ciocaltea@collabora.com \
--cc=Syed.SabaKareem@amd.com \
--cc=Vijendar.Mukunda@amd.com \
--cc=alsa-devel@alsa-project.org \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=kernel@collabora.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=rdunlap@infradead.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox