From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45763C433E0 for ; Fri, 3 Jul 2020 08:00:01 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B887820772 for ; Fri, 3 Jul 2020 08:00:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="a/qrdmVo"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ti.com header.i=@ti.com header.b="RJajxqja" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B887820772 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=ti.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 261A016C0; Fri, 3 Jul 2020 09:59:09 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 261A016C0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1593763199; bh=Uir5HRsEaAIQuDuskoIqOnUU+BYP1mPCuUeVlbjqMYk=; h=Subject:To:References:From:Date:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=a/qrdmVoUMwYg3l6nWXZPBLbm3TeseXV5uHsLQsIcu5N9jPm6DwT1xGF6eB7tXfX9 6KrNKkQzVwtxJKBeJPw2v5UFmj6X801KwSyLfczKOymdFcr2bfeVe9klLRFvBZlT4c erXVGbqRQOYNIeId60VaDewWOqzGmwe4u/n5SbxE= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 9EC42F800E0; Fri, 3 Jul 2020 09:59:08 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 118EDF80217; Fri, 3 Jul 2020 09:59:07 +0200 (CEST) Received: from fllv0016.ext.ti.com (fllv0016.ext.ti.com [198.47.19.142]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id E74AEF800E0 for ; Fri, 3 Jul 2020 09:59:00 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz E74AEF800E0 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="RJajxqja" Received: from lelv0266.itg.ti.com ([10.180.67.225]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 0637wv62049460; Fri, 3 Jul 2020 02:58:57 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1593763137; bh=hRJk4qExkZmvzEg1cgK9sURYCcpGTnP5CZ1jdi0sLm0=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=RJajxqjaSvfdCZBLLTpNvGjpgM/SJyVwjTHopxbF9qAscEtreGY/BkVdSmtCsaZFm uZXD1wAfnH9GLc/FOS1l0yi0hlp0ilj/Y+BYaUFuOy2a4fT15LJ21bDwVx0DL5NSnD R1lbKGGSLer/UIZRLSZjEHqnBlLq9AdL0p6Fha+w= Received: from DFLE115.ent.ti.com (dfle115.ent.ti.com [10.64.6.36]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 0637wvJH090818 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 3 Jul 2020 02:58:57 -0500 Received: from DFLE100.ent.ti.com (10.64.6.21) by DFLE115.ent.ti.com (10.64.6.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3; Fri, 3 Jul 2020 02:58:57 -0500 Received: from fllv0040.itg.ti.com (10.64.41.20) by DFLE100.ent.ti.com (10.64.6.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3 via Frontend Transport; Fri, 3 Jul 2020 02:58:57 -0500 Received: from [192.168.2.6] (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0040.itg.ti.com (8.15.2/8.15.2) with ESMTP id 0637wtXp122879; Fri, 3 Jul 2020 02:58:55 -0500 Subject: Re: [PATCH -next] ASoC: ti: j721e-evm: Fix missing unlock on error in j721e_audio_hw_params() To: Wei Yongjun , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai References: <20200703030910.75047-1-weiyongjun1@huawei.com> From: Peter Ujfalusi X-Pep-Version: 2.0 Message-ID: <8ab2ddf8-88db-a5e5-b97a-76b4fe014bdd@ti.com> Date: Fri, 3 Jul 2020 10:59:55 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 MIME-Version: 1.0 In-Reply-To: <20200703030910.75047-1-weiyongjun1@huawei.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Cc: Hulk Robot , alsa-devel@alsa-project.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On 03/07/2020 6.09, Wei Yongjun wrote: > Add the missing unlock before return from function j721e_audio_hw_param= s() > in the error handling case. I'm not sure how that return made it in there in the first place.. Acked-by: Peter Ujfalusi > Fixes: 6748d0559059 ("ASoC: ti: Add custom machine driver for j721e EVM= (CPB and IVI)") > Reported-by: Hulk Robot > Signed-off-by: Wei Yongjun > --- > sound/soc/ti/j721e-evm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/sound/soc/ti/j721e-evm.c b/sound/soc/ti/j721e-evm.c > index 3a2a8b1f3aa3..174306cf53ad 100644 > --- a/sound/soc/ti/j721e-evm.c > +++ b/sound/soc/ti/j721e-evm.c > @@ -330,7 +330,7 @@ static int j721e_audio_hw_params(struct snd_pcm_sub= stream *substream, > ret =3D snd_soc_dai_set_tdm_slot(codec_dai, 0x3, 0x3, 2, > slot_width); > if (ret && ret !=3D -ENOTSUPP) > - return ret; > + goto out; > } > =20 > ret =3D j721e_configure_refclk(priv, domain_id, params_rate(params));= >=20 >=20 >=20 - P=C3=A9ter Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki