From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B29C3C433E0 for ; Tue, 2 Feb 2021 15:26:40 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 20D3164F05 for ; Tue, 2 Feb 2021 15:26:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 20D3164F05 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 9F64E172F; Tue, 2 Feb 2021 16:25:46 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 9F64E172F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1612279596; bh=pP4RFe8gnSbR6RtAOvcwSni1rrgvsp8t0HsaWcqWJU4=; h=Subject:To:References:From:Date:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=iv7+gCBTw6gu/IgD0FnCO9QmwnOW1sxlPiD37UFGj1/tL4Ps3cu7GTtzLtBp37zWf wo6erK4fyPdPa2pcsPVY1pFUE2rxKLDulkfOHuC5dbBvLpaFbkTMX2gbFD0bvDx/qH tlLSF5VoKcOaxbBry2DhJqaFfovLgRLOizu4IAJE= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 1E515F800E1; Tue, 2 Feb 2021 16:25:46 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id A22E4F80171; Tue, 2 Feb 2021 16:25:44 +0100 (CET) Received: from mail-lj1-x234.google.com (mail-lj1-x234.google.com [IPv6:2a00:1450:4864:20::234]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 3F8EDF800E1 for ; Tue, 2 Feb 2021 16:25:36 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 3F8EDF800E1 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Vv94kslT" Received: by mail-lj1-x234.google.com with SMTP id s18so24413534ljg.7 for ; Tue, 02 Feb 2021 07:25:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=1BFhguJtknsgKZxynMp8586vauMG7FnrvbgtjYyZdro=; b=Vv94kslTjxOHCof/KEF/LoLKR4nL5ltWMvPcoQIXsSRavJWqtYBiP4QkJfugy6ZSHw QF/4EXVfa3lenAfwmQje7P49RcR1YghY0PCAU//9kv0OcVTFjTz+s6MTZsuDvoxeNQBg VhJHmLc35E4FARCFj1km/HlUqEq5qSdKlViFF05bIHJYnduqZRrIF/W9XUC7LvaYe2wg H1qPnPgPgF1ij8aDO/c1c+3R7ZGttCyFlLtxcYJiYN+c2/hWbqX0cqLcTFyW4c+9bQO4 8eoNEKdfAyzCfqpFKMhgFKZr15lZL86pIdGoUv/Neqjn/opYp+dRlJF99YQ2/8WOcbaG 28Sw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=1BFhguJtknsgKZxynMp8586vauMG7FnrvbgtjYyZdro=; b=CsUZEemAE6EaNr7OjTNT+71cXBpWwobgzaJrsh/ewWWLRoacqukiWNqrI9t8Lb4PQ7 tPz6sqdB2w7p3xOqrs6FWXxknMGq1ZZicSE8oQpdFOVvotlK23a6ryfqGX/4mAE00EGI AKb238gWqQCLGpECxuYR0JqxWWO5m+jfgYtPHXsWG3ADi2QdnAm3odm6ChE5yYdHBm7H 3T+LSfExi7qZf3Je/azxDxuXoFqDLfX+FHA9tDK2xWDeqm1sAiaSskOt20MIsdJOlSkO +bsMub99Wz7r/mNf83B1XpPWFc6KZCridwz1hsBtE5mYFpkZI9M/uQ3++RFQhrkXsXh2 QpEw== X-Gm-Message-State: AOAM5310DTwYpAPZKvWwuSjM1AGSCymHKLCNt6k5RN5vYy3Wc3RyeMSd SK+OJVgyaDMhJ2C4r5P2lJI= X-Google-Smtp-Source: ABdhPJy9CrYxZnEFUlb+AY6IJgJ2nx7yfz9iiAllAC8BTXE/k9hwCGANIk8LURd2z3PsTK23pF1mFg== X-Received: by 2002:a2e:7c16:: with SMTP id x22mr13561352ljc.46.1612279536183; Tue, 02 Feb 2021 07:25:36 -0800 (PST) Received: from ?IPv6:2a00:1370:814d:ea25:a10:76ff:fe69:21b6? ([2a00:1370:814d:ea25:a10:76ff:fe69:21b6]) by smtp.googlemail.com with ESMTPSA id s19sm2604205ljg.43.2021.02.02.07.25.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 02 Feb 2021 07:25:35 -0800 (PST) Subject: Re: [PATCH v1 2/2] ASoC: tegra: Add RT5631 machine driver To: Jon Hunter , Ion Agorria , Thierry Reding , Stephen Warren , Liam Girdwood , Mark Brown , Takashi Iwai , Jaroslav Kysela , Rob Herring , Svyatoslav Ryhel , Ion Agorria References: <20210131184101.651486-1-AG0RRIA@yahoo.com> <20210131184101.651486-3-AG0RRIA@yahoo.com> <7f4eb8f7-215e-ab3d-fcef-9243037cf246@nvidia.com> From: Dmitry Osipenko Message-ID: <8d0bc6f3-45ce-565d-d80f-b50fb75e7c55@gmail.com> Date: Tue, 2 Feb 2021 18:25:34 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.2 MIME-Version: 1.0 In-Reply-To: <7f4eb8f7-215e-ab3d-fcef-9243037cf246@nvidia.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Cc: linux-tegra@vger.kernel.org, devicetree@vger.kernel.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" 02.02.2021 16:22, Jon Hunter пишет: > So this is very similar to tegra_rt5677, is it not possible to support > both codecs with the same machine driver? These codecs require individual configurations and those "../codecs/rt5631.h" and "../codecs/rt5677.h" aren't compatible at a quick glance. The tegra_rt5677 also uses outdated GPIO API and etc. Hence the new driver should be a better base anyways. Overall it shouldn't worth time and effort trying to squeeze these drivers into a single one, IMO.