From: "Nobin Mathew" <nobin.mathew@gmail.com>
To: Liam Girdwood <lg@opensource.wolfsonmicro.com>
Cc: Takashi Iwai <tiwai@suse.de>, alsa-devel@alsa-project.org
Subject: Re: Power management state flow in ALSA
Date: Wed, 6 Jun 2007 13:37:00 +0530 [thread overview]
Message-ID: <8d6898730706060107r2952c8d2i843ba68b0b8c6b40@mail.gmail.com> (raw)
In-Reply-To: <8d6898730706032158i341b70d3j32c9566532395d18@mail.gmail.com>
Liam,
In soc_resume()
we should do this
snd_power_change_state(codec->card, SNDRV_CTL_POWER_D0);
instead of
snd_power_change_state(codec->card, SNDRV_CTL_POWER_D3hot);
Because snd_pcm_resume in pcm_native.c expects the card to be in
SNDRV_CTL_POWER_D0 state. Other ioctl will wait forever.
static int snd_pcm_resume(struct snd_pcm_substream *substream)
{
struct snd_card *card = substream->pcm->card;
int res;
snd_power_lock(card);
if ((res = snd_power_wait(card, SNDRV_CTL_POWER_D0)) >= 0)
res = snd_pcm_action_lock_irq(&snd_pcm_action_resume, substream, 0);
snd_power_unlock(card);
return res;
}
One more thing why we are using
snd_power_change_state(codec->card, SNDRV_CTL_POWER_D3cold);
every other driver is doing
snd_power_change_state(card, SNDRV_CTL_POWER_D3hot);
SNDRV_CTL_POWER_D3cold is true for deep sleep where power to the
controller is switched off .
In sleep, only clock to the controller is switched off.
Nobin Mathew
On 6/4/07, Nobin Mathew <nobin.mathew@gmail.com> wrote:
> Liam
>
> I will get back, i need to set up the board
>
> On 6/1/07, Liam Girdwood <lg@opensource.wolfsonmicro.com> wrote:
> > Nobin,
> >
> > Can you try the following patch :-
> >
> > http://opensource.wolfsonmicro.com/cgi-bin/gitweb/gitweb.cgi?p=linux-2.6-asoc;a=commit;h=6c868238a5e083dca4d74439a7fd467b5c7726b0
> >
> > This will notify pcm's of their suspend state.
> >
> > Liam
> >
> > On Wed, 2007-05-30 at 12:58 +0200, Takashi Iwai wrote:
> > > At Wed, 30 May 2007 16:06:54 +0530,
> > > Nobin Mathew wrote:
> > > >
> > > > I am writing an ASoC driver, where i can place these calls
> > > >
> > > > snd_power_change_state(card, SNDRV_CTL_POWER_D3hot);
> > > > snd_pcm_suspend_all(chip->pcm[i]);
> > > >
> > > > and snd_power_change_state(card, SNDRV_CTL_POWER_D0);
> > > >
> > > >
> > > > In soc-core.c ?
> > >
> > > I suppose so.
> > > In soc_suspend() and soc_resume(), you can get the card instance from
> > > codec->card, at least.
> > >
> > > But currently SoC doesn't keep the PCM instances, so it cannot be
> > > implemented as it is... Liam, any plan or known issue regarding this?
> > >
> > >
> > > Takashi
> >
> >
>
prev parent reply other threads:[~2007-06-06 8:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-30 6:22 Power management state flow in ALSA Nobin Mathew
2007-05-30 9:55 ` Takashi Iwai
2007-05-30 10:06 ` Nobin Mathew
2007-05-30 10:26 ` Takashi Iwai
2007-05-30 10:36 ` Nobin Mathew
2007-05-30 10:39 ` Takashi Iwai
2007-05-30 10:46 ` Nobin Mathew
2007-05-30 10:58 ` Takashi Iwai
2007-05-30 11:10 ` Liam Girdwood
2007-06-01 12:18 ` Liam Girdwood
[not found] ` <8d6898730706032158i341b70d3j32c9566532395d18@mail.gmail.com>
2007-06-06 8:07 ` Nobin Mathew [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8d6898730706060107r2952c8d2i843ba68b0b8c6b40@mail.gmail.com \
--to=nobin.mathew@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=lg@opensource.wolfsonmicro.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).