From: "Nobin Mathew" <nobin.mathew@gmail.com>
To: Liam Girdwood <lg@opensource.wolfsonmicro.com>
Cc: alsa-devel@alsa-project.org
Subject: [ASoC]Changing the order of trigger in soc_pcm_trigger
Date: Wed, 6 Jun 2007 18:36:52 +0530 [thread overview]
Message-ID: <8d6898730706060606ree4bb6ahf8b4fd0b07453408@mail.gmail.com> (raw)
Liam,
I have one suggestion.
Can we use this
if (rtd->codec_dai->ops.trigger) {
ret = rtd->codec_dai->ops.trigger(substream, cmd);
if (ret < 0)
return ret;
}
if (rtd->cpu_dai->ops.trigger) {
ret = rtd->cpu_dai->ops.trigger(substream, cmd);
if (ret < 0)
return ret;
}
if (platform->pcm_ops->trigger) {
ret = platform->pcm_ops->trigger(substream, cmd);
if (ret < 0)
return ret;
}
Instead of
if (rtd->codec_dai->ops.trigger) {
ret = rtd->codec_dai->ops.trigger(substream, cmd);
if (ret < 0)
return ret;
}
if (platform->pcm_ops->trigger) {
ret = platform->pcm_ops->trigger(substream, cmd);
if (ret < 0)
return ret;
}
if (rtd->cpu_dai->ops.trigger) {
ret = rtd->cpu_dai->ops.trigger(substream, cmd);
if (ret < 0)
return ret;
}
That means trigger the Cpu before pcm. Because most of the controllers
needs to be initialized and triggered before external DMA is
triggered.
Correct me if i am going wrong.
This was causing so many problems in my hardware.
Nobin Mathew
next reply other threads:[~2007-06-06 13:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-06 13:06 Nobin Mathew [this message]
2007-06-06 13:24 ` [ASoC]Changing the order of trigger in soc_pcm_trigger Liam Girdwood
2007-06-06 13:24 ` Nobin Mathew
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8d6898730706060606ree4bb6ahf8b4fd0b07453408@mail.gmail.com \
--to=nobin.mathew@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=lg@opensource.wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).